Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies #116

Merged
merged 4 commits into from
Mar 28, 2024
Merged

feat: update dependencies #116

merged 4 commits into from
Mar 28, 2024

Conversation

NuttyShrimp
Copy link
Member

Swagger went BRRR

@NuttyShrimp NuttyShrimp requested a review from FKD13 March 25, 2024 22:01
Copy link
Member

@FKD13 FKD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still compiles and runs 🎉

Some remarks:

  • We have lost our swagger endpoint grouping (everything is grouped under "default")
  • do we want to update to java 21?
  • this option seems to influence nothing?
    scr
  • my ide seems happier with the bottom version :D
    scr

@NuttyShrimp
Copy link
Member Author

I take a look at the swagger endpoint group but can't promise anything, the docs are pretty shit.

The sourceCompatibility definitely does something, it is used by the java plugin.
See what happens when I try to run the tests with compatibility set to 19 on a 17 sdk
image

We can upgrade to 21, but there are no new exciting features and 17 is backwards compatible with 21 so the peeps in their first year do not really need to download 17 (and I don't need to upgrade my SDK)

@NuttyShrimp
Copy link
Member Author

  • Fxed the swagger grouping
  • Changed that build thing in the gradle file
  • Rebased onto development

@NuttyShrimp NuttyShrimp requested a review from FKD13 March 28, 2024 14:44
@FKD13
Copy link
Member

FKD13 commented Mar 28, 2024

My migrations are currently failing with error:

No database found to handle jdbc:postgresql://localhost:5432/telraam_dev

Probably linked to flyway/flyway#3722

Copy link
Member

@FKD13 FKD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the swagger still looks the same 🎉

@NuttyShrimp NuttyShrimp merged commit 8f9e453 into development Mar 28, 2024
1 check passed
@NuttyShrimp NuttyShrimp deleted the update-deps branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants