Skip to content

Commit

Permalink
board.jsx: Remove error message
Browse files Browse the repository at this point in the history 
Removes error message because a modal has been implemented.

Fixes coala#127
  • Loading branch information
@123vivekr
123vivekr committed Jan 17, 2019
1 parent 33373e6 commit 40c6ae9
Showing 1 changed file with 128 additions and 127 deletions.
255 changes: 128 additions & 127 deletions src/components/board.jsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,139 +12,140 @@ import Progress from '../progress';
import Database from '../database';

class ProgressView extends Component {
state = {message: null, ticks: 0, max: 0};

componentDidMount() {
const {progress} = this.props;
progress.on('start', this.onStart);
progress.on('tick', this.onTick);
progress.on('stop', this.onStop);
}

componentWillUnmount() {
const {progress} = this.props;
progress.off('start', this.onStart);
progress.off('tick', this.onTick);
progress.off('stop', this.onStop);
}

onStart = (context) => { this.setState({max: this.props.progress.max, message: 'Start: ' + context}); };

onTick = (context, ticks, max) => {
this.setState({ticks: ticks, max: max, message: context});
this.forceUpdate();
};

onStop = (context) => {
this.setState({
ticks: this.props.progress.ticks,
max: this.props.progress.max,
message: 'Finished: ' + context
});
};

render() {
const {ticks, max} = this.state;
const {message} = this.state;
const label = `${ticks}/${max}`;

// TODO: Use Loadable component
return (
<div className="is-loading">
<BS.ProgressBar now={ticks} max={max} label={label}/>
<SyncIcon className='icon-spin'/> {message}
</div>
);
}
}
state = {message: null, ticks: 0, max: 0};

class Board extends Component {
static propTypes = {
type: PropTypes.func.isRequired, // A React Component
repoInfos: PropTypes.array.isRequired,
columnDataPromise: PropTypes.object.isRequired
};

componentDidMount() {
IssueStore.on('change', this.onChange);
FilterStore.on('change', this.onChange);
SettingsStore.on('change', this.onChange);
SettingsStore.on('change:showPullRequestData', this.onChangeAndRefetch);
}

componentWillUnmount() {
IssueStore.off('change', this.onChange);
FilterStore.off('change', this.onChange);
SettingsStore.off('change', this.onChange);
SettingsStore.off('change:showPullRequestData', this.onChangeAndRefetch);
}

onChangeAndRefetch = () => {
IssueStore.clearCacheCards();
this.forceUpdate();
};

onChange = () => {
this.setState({});
};

onLabelsChanged = () => {
this.setState({});
};

// Curried func to squirrell the primaryRepoName var
renderKanbanRepos = (repoInfos) => {
const {type} = this.props;

return ([columnData, cards]) => {

if (cards.length) {
return React.createElement(type, {columnData, cards, repoInfos});
} else {
componentDidMount() {
const {progress} = this.props;
progress.on('start', this.onStart);
progress.on('tick', this.onTick);
progress.on('stop', this.onStop);
}

componentWillUnmount() {
const {progress} = this.props;
progress.off('start', this.onStart);
progress.off('tick', this.onTick);
progress.off('stop', this.onStop);
}

onStart = (context) => { this.setState({max: this.props.progress.max, message: 'Start: ' + context}); };

onTick = (context, ticks, max) => {
this.setState({ticks: ticks, max: max, message: context});
this.forceUpdate();
};

onStop = (context) => {
this.setState({
ticks: this.props.progress.ticks,
max: this.props.progress.max,
message: 'Finished: ' + context
});
};

render() {
const {ticks, max} = this.state;
const {message} = this.state;
const label = `${ticks}/${max}`;

// TODO: Use Loadable component
return (
<div className='-no-issues'>
<h2>No Issues to show</h2>
<p>There are no Issues to show. Maybe the repository does not have any or an applied filter removes all Issues.</p>
</div>
<div className="is-loading">
<BS.ProgressBar now={ticks} max={max} label={label}/>
<SyncIcon className='icon-spin'/> {message}
</div>
);
}
}
}

class Board extends Component {
static propTypes = {
type: PropTypes.func.isRequired, // A React Component
repoInfos: PropTypes.array.isRequired,
columnDataPromise: PropTypes.object.isRequired
};

componentDidMount() {
IssueStore.on('change', this.onChange);
FilterStore.on('change', this.onChange);
SettingsStore.on('change', this.onChange);
SettingsStore.on('change:showPullRequestData', this.onChangeAndRefetch);
}

componentWillUnmount() {
IssueStore.off('change', this.onChange);
FilterStore.off('change', this.onChange);
SettingsStore.off('change', this.onChange);
SettingsStore.off('change:showPullRequestData', this.onChangeAndRefetch);
}

onChangeAndRefetch = () => {
IssueStore.clearCacheCards();
this.forceUpdate();
};

onChange = () => {
this.setState({});
};

onLabelsChanged = () => {
this.setState({});
};

// Curried func to squirrell the primaryRepoName var
renderKanbanRepos = (repoInfos) => {
const {type} = this.props;

return ([columnData, cards]) => {

if (cards.length) {
return React.createElement(type, {columnData, cards, repoInfos});
} else {
return (
<div className='-no-issues'>
<h2>No Issues to show</h2>
<p>There are no Issues to show. Maybe the repository does not have any or an applied filter removes all Issues.</p>
</div>
);
}

};
};

renderError = (err) => {
console.error(err);
if (err.name === 'InvalidStateError') {
return (
<span>It looks like your browser is in private browsing mode. gh-board uses IndexedDB to cache requests to GitHub. Please disable Private Browsing to see it work.</span>
);
} else {
return (
<br />
// <span>
// Problem loading. Is it a valid repo? And have you exceeded your number of requests? Usually happens when not logged in because GitHub limits anonymous use of their API.
// {err.message}
// {JSON.stringify(err)}
// </span>
);
}
};
};

renderError = (err) => {
console.error(err);
if (err.name === 'InvalidStateError') {
return (
<span>It looks like your browser is in private browsing mode. gh-board uses IndexedDB to cache requests to GitHub. Please disable Private Browsing to see it work.</span>
);
} else {
return (
<span>
Problem loading. Is it a valid repo? And have you exceeded your number of requests? Usually happens when not logged in because GitHub limits anonymous use of their API.
{err.message}
{JSON.stringify(err)}
</span>
);

render() {
const {repoInfos, columnDataPromise} = this.props;
const progress = new Progress();
const cardsPromise = IssueStore.fetchIssues().then((cards) => {
return Database.fetchCards(getFilters()) || cards;
});

return (
<Loadable key='board'
promise={Promise.all([columnDataPromise, cardsPromise])}
renderLoading={() => (<ProgressView progress={progress}/>)}
renderLoaded={this.renderKanbanRepos(repoInfos)}
renderError={this.renderError}
/>
);
}
};

render() {
const {repoInfos, columnDataPromise} = this.props;
const progress = new Progress();
const cardsPromise = IssueStore.fetchIssues().then((cards) => {
return Database.fetchCards(getFilters()) || cards;
});

return (
<Loadable key='board'
promise={Promise.all([columnDataPromise, cardsPromise])}
renderLoading={() => (<ProgressView progress={progress}/>)}
renderLoaded={this.renderKanbanRepos(repoInfos)}
renderError={this.renderError}
/>
);
}
}

export default Board;

0 comments on commit 40c6ae9

Please sign in to comment.