Move stylistic eslint rules to prettier #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
commented
Nov 11, 2023
| "useTabs": true, | ||
| "singleQuote": false, | ||
| "semi": true, | ||
| "endOfLine": "lf", |
There was a problem hiding this comment.
Some of these options are duplicates since Prettier respects the .editorconfig file settings, your choice if you want to be extra specific here (useTabs and endOfLine are already in the .editorconfig).
|
Once this is resolved I think we should adopt the current state of |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we shouldn't be using stylistic rules with Eslint since we already have Prettier, and you've already encountered some conflicts (424a4bf, 88fe5ef). This PR moves stylistic rules to Prettier and adds the
eslint-config-prettierpackage to disable conflicts.