-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to explain how WP_Mock TestCase is preferable to extend than PhpUnit's #239
Update docs to explain how WP_Mock TestCase is preferable to extend than PhpUnit's #239
Conversation
FTR: I don't use it by extending |
@BrianHenryIE that is correct - as mentioned in the docs we are updating in this PR, you can override precisely those two methods to achieve the same thing. However, it's simpler to tell people to extend WP_Mock own test case (which in turn extends PHPUnit's own test case anyway). We mention the alternative you are using in the docs as per this PR. Feel free to comment further if you think we should add anything else, thank you! |
Co-authored-by: Ryan Neudorf <[email protected]>
Co-authored-by: Drew Jaynes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Big improvement.
Summary
Updates docs to make it clear that implementations should use WP_Mock own
TestCase
, ideally, or at least provide teardown overrides.Closes: #238
Contributor checklist
Reviewer checklist
TestCase