Update handling of css globals & mixins #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
requested review from
Antonio-Laguna,
darylldoyle,
joesnellpdx and
nicholasio
7 tasks
Antonio-Laguna
approved these changes
Apr 22, 2024
darylldoyle
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is not yet ready to test because the change in Toolkit has not yet been released and therefore the code here in this branch does not currently work.
Description of the Change
This PR updates the scaffold to use the new globals handling approach developed in 10up/10up-toolkit#389
Changelog Entry
Credits
Props @fabiankaegy @Antonio-Laguna @nicholasio
Checklist: