Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled buttons in distributed posts #1252

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

phpbits
Copy link
Contributor

@phpbits phpbits commented Jul 24, 2024

Description of the Change

This PR fixes the #1249 issues.

Closes #1249

How to test the Change

Update the site you distributed the post to WP 6.6 and/or distribute a post with the "As draft" checkbox checked to a site that is running WP 6.6. Observe that the Publish button is enabled and publish button is working.

Changelog Entry

Fixed - Bug fix

Credits

Props @phpbits

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@phpbits phpbits requested a review from a team as a code owner July 24, 2024 12:26
@phpbits phpbits requested review from peterwilsoncc and removed request for a team July 24, 2024 12:26
@github-actions github-actions bot added this to the 2.1.0 milestone Jul 24, 2024
Copy link

@phpbits thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:feedback This requires reporter feedback to better understand the request. needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jul 24, 2024
Copy link

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue. Thanks

@dkotter dkotter requested a review from faisal-alvi August 14, 2024 14:15
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @phpbits!

✅ Tests well.

I've tested in the following setups, and it works fine:

Setup WordPress Version Status
External connection v6.6.1
External connection v6.4.3
Multisite network (Internal) v6.5.5

Note: Ignoring E2E failures as they are unrelated and also occurring in the develop branch.

@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
@dkotter dkotter merged commit 16b0df7 into develop Aug 15, 2024
17 of 18 checks passed
@dkotter dkotter deleted the fix/1249-post-status branch August 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WP 6.6] Impossible to publish post if distributed as draft
4 participants