Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all actions we use in our workflows to pull from specific pinned commits #135

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Mar 18, 2025

Description of the Change

As touched on here, in order to protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull them based on the commit hash from the latest release.

While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.

How to test the Change

Ensure all our workflows still run as expected

Changelog Entry

Developer - Update all third-party actions our workflows rely on to use versions based on specific commit hashes.

Credits

Props @dkotter, @jeffpaul

Checklist:

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting on this so quickly!

@dkotter dkotter merged commit 2789309 into develop Mar 19, 2025
@dkotter dkotter deleted the update/pin-workflow-actions branch March 19, 2025 15:51
github-actions bot pushed a commit that referenced this pull request Mar 19, 2025
…w-actions

Update all actions we use in our workflows to pull from specific pinned commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants