Update action examples to install svn #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
iamdharmesh
and removed request for
a team and
jeffpaul
iamdharmesh
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Hi @thrijith,
Thanks a lot for the PR, it looks good to me. Just a minor suggestion around installing the package, based on GH action docs. Could you please check it once?
Thank you.
Comment on lines
+67
to
+68
| - name: Install SVN ( Subversion ) | ||
| run: sudo apt-get install subversion |
There was a problem hiding this comment.
It is better to run sudo apt-get update before installing a package. As suggested in a note here.
Suggested change
| - name: Install SVN ( Subversion ) | |
| run: sudo apt-get install subversion | |
| - name: Install SVN ( Subversion ) | |
| run: | | |
| sudo apt-get update | |
| sudo apt-get install subversion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates the example to install svn same as it is done in 10up/action-wordpress-plugin-deploy#155
Closes N/A