Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: custom-property-pattern to also match single - separators #369

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Feb 19, 2024

Related Issue/RFC: #

Description of the Change

Update custom-property-pattern to also match single - separators. This is needed for things like --wp--preset--font-family--system-font. The way WordPress generated properties is by adding a single - in place of any camelCased variables camel-case. Nesting levels get turned to --

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 5734ef9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@10up/stylelint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabiankaegy fabiankaegy merged commit 5f69847 into develop Feb 20, 2024
5 checks passed
@fabiankaegy fabiankaegy deleted the fix/wp-custom-property-pattern branch February 20, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants