Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Stylelint to 15.0.0 #298

Merged
merged 15 commits into from
Oct 5, 2023
Merged

Updates Stylelint to 15.0.0 #298

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ae2fa30
Updates Stylelint to 15.0.0
Antonio-Laguna May 31, 2023
7f61b77
Picking up from .editorconfig
Antonio-Laguna May 31, 2023
f76b35f
Updating snapshot
Antonio-Laguna Jul 3, 2023
fe06890
Ensuring optional package is installed on dev
Antonio-Laguna Jul 3, 2023
faefae5
Merge branch 'develop' into feature/stylelint-upgrade
Antonio-Laguna Jul 20, 2023
d9246a6
Merge branch 'develop' into feature/stylelint-upgrade
Antonio-Laguna Aug 2, 2023
e7d6f97
Porting from #314
Antonio-Laguna Aug 2, 2023
5fe5d7e
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Sep 25, 2023
d5e6c59
update snapshots
nicholasio Sep 25, 2023
1d73345
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Sep 25, 2023
9def914
Migrating 10up-theme to React 18
Antonio-Laguna Oct 4, 2023
5ab6f90
Updating packages again
Antonio-Laguna Oct 4, 2023
760575f
Ensuring currentcolor works
Antonio-Laguna Oct 4, 2023
61b1575
Same import for all
Antonio-Laguna Oct 4, 2023
f68c04e
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-trees-pump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@10up/stylelint-config": major
---

Upgrading `stylelint` to version `15.0.0` and decouple from `@wordpress/stylelint-config`.
14,790 changes: 9,246 additions & 5,544 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

196 changes: 55 additions & 141 deletions packages/babel-preset-default/__tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,26 @@ Object.defineProperty(exports, \\"__esModule\\", {
});
exports.default = void 0;
var _react = require(\\"react\\");
var _jsxRuntime = require(\\"react/jsx-runtime\\");
// eslint-disable-line import/no-extraneous-dependencies
// eslint-disable-line import/no-extraneous-dependencies

const FCComponent = ({
title,
url,
description
}) => /*#__PURE__*/React.createElement(\\"div\\", {
className: \\"component-test-babel\\"
}, /*#__PURE__*/React.createElement(\\"a\\", {
href: url,
title: title
}, /*#__PURE__*/React.createElement(\\"h1\\", null, title)), /*#__PURE__*/React.createElement(\\"p\\", null, description));
}) => /*#__PURE__*/(0, _jsxRuntime.jsxs)(\\"div\\", {
className: \\"component-test-babel\\",
children: [/*#__PURE__*/(0, _jsxRuntime.jsx)(\\"a\\", {
href: url,
title: title,
children: /*#__PURE__*/(0, _jsxRuntime.jsx)(\\"h1\\", {
children: title
})
}), /*#__PURE__*/(0, _jsxRuntime.jsx)(\\"p\\", {
children: description
})]
});
FCComponent.defaultProps = {
title: '',
url: '',
Expand All @@ -104,13 +111,15 @@ class ClassComponent extends _react.Component {
const {
title
} = this.props;
return /*#__PURE__*/React.createElement(\\"div\\", {
className: \\"Class Component\\"
}, /*#__PURE__*/React.createElement(\\"h1\\", null, title));
return /*#__PURE__*/(0, _jsxRuntime.jsx)(\\"div\\", {
className: \\"Class Component\\",
children: /*#__PURE__*/(0, _jsxRuntime.jsx)(\\"h1\\", {
children: title
})
});
}
}
var _default = FCComponent;
exports.default = _default;"
var _default = exports.default = FCComponent;"
`;

exports[`Babel preset default transpiles without removing proptypes in dev mode 1`] = `
Expand All @@ -122,46 +131,42 @@ Object.defineProperty(exports, \\"__esModule\\", {
exports.default = void 0;
var _react = require(\\"react\\");
var _propTypes = _interopRequireDefault(require(\\"prop-types\\"));
var _jsxDevRuntime = require(\\"react/jsx-dev-runtime\\");
var _jsxFileName = \\"\\"; // eslint-disable-line import/no-extraneous-dependencies
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
// eslint-disable-line import/no-extraneous-dependencies

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
const FCComponent = ({
title,
url,
description
}) => /*#__PURE__*/React.createElement(\\"div\\", {
}) => /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"div\\", {
className: \\"component-test-babel\\",
__self: void 0,
__source: {
fileName: _jsxFileName,
lineNumber: 5,
columnNumber: 2
}
}, /*#__PURE__*/React.createElement(\\"a\\", {
href: url,
title: title,
__self: void 0,
__source: {
children: [/*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"a\\", {
href: url,
title: title,
children: /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"h1\\", {
children: title
}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 7,
columnNumber: 4
}, void 0)
}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 6,
columnNumber: 3
}
}, /*#__PURE__*/React.createElement(\\"h1\\", {
__self: void 0,
__source: {
fileName: _jsxFileName,
lineNumber: 7,
columnNumber: 4
}
}, title)), /*#__PURE__*/React.createElement(\\"p\\", {
__self: void 0,
__source: {
}, void 0), /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"p\\", {
children: description
}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 9,
columnNumber: 3
}
}, description));
}, void 0)]
}, void 0, true, {
fileName: _jsxFileName,
lineNumber: 5,
columnNumber: 2
}, void 0);
FCComponent.propTypes = {
title: _propTypes.default.string,
url: _propTypes.default.string,
Expand All @@ -180,29 +185,26 @@ class ClassComponent extends _react.Component {
const {
title
} = this.props;
return /*#__PURE__*/React.createElement(\\"div\\", {
return /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"div\\", {
className: \\"Class Component\\",
__self: this,
__source: {
fileName: _jsxFileName,
lineNumber: 33,
columnNumber: 4
}
}, /*#__PURE__*/React.createElement(\\"h1\\", {
__self: this,
__source: {
children: /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)(\\"h1\\", {
children: title
}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 34,
columnNumber: 5
}
}, title));
}, this)
}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 33,
columnNumber: 4
}, this);
}
}
ClassComponent.propTypes = {
title: _propTypes.default.string.isRequired
};
var _default = FCComponent;
exports.default = _default;"
var _default = exports.default = FCComponent;"
`;

exports[`Babel preset default transpiles without transforming es6 imports 1`] = `
Expand Down Expand Up @@ -278,95 +280,7 @@ class ClassComponent extends _react.Component {
}, (0, _element.createElement)(\\"h1\\", null, title));
}
}
var _default = FCComponent;
exports.default = _default;"
`;

exports[`Babel preset default with automatic runtime transpiles react code properly with automatic runtime 1`] = `
"\\"use strict\\";

Object.defineProperty(exports, \\"__esModule\\", {
value: true
});
exports.default = void 0;
var _react = require(\\"react\\");
// eslint-disable-line import/no-extraneous-dependencies
// eslint-disable-line import/no-extraneous-dependencies

const FCComponent = ({
title,
url,
description
}) => /*#__PURE__*/React.createElement(\\"div\\", {
className: \\"component-test-babel\\"
}, /*#__PURE__*/React.createElement(\\"a\\", {
href: url,
title: title
}, /*#__PURE__*/React.createElement(\\"h1\\", null, title)), /*#__PURE__*/React.createElement(\\"p\\", null, description));
FCComponent.defaultProps = {
title: '',
url: '',
description: ''
};
class ClassComponent extends _react.Component {
componentDidMount() {
// doing something
}
render() {
const {
title
} = this.props;
return /*#__PURE__*/React.createElement(\\"div\\", {
className: \\"Class Component\\"
}, /*#__PURE__*/React.createElement(\\"h1\\", null, title));
}
}
var _default = FCComponent;
exports.default = _default;"
`;

exports[`Babel preset default with automatic runtime transpiles wordpress code properly even when jsx-runtime.js is present 1`] = `
"\\"use strict\\";

Object.defineProperty(exports, \\"__esModule\\", {
value: true
});
exports.default = void 0;
var _element = require(\\"@wordpress/element\\");
var _react = require(\\"react\\");
// eslint-disable-line import/no-extraneous-dependencies
// eslint-disable-line import/no-extraneous-dependencies

const FCComponent = ({
title,
url,
description
}) => (0, _element.createElement)(\\"div\\", {
className: \\"component-test-babel\\"
}, (0, _element.createElement)(\\"a\\", {
href: url,
title: title
}, (0, _element.createElement)(\\"h1\\", null, title)), (0, _element.createElement)(\\"p\\", null, description));
FCComponent.defaultProps = {
title: '',
url: '',
description: ''
};
class ClassComponent extends _react.Component {
componentDidMount() {
// doing something
}
render() {
const {
title
} = this.props;
return (0, _element.createElement)(\\"div\\", {
className: \\"Class Component\\"
}, (0, _element.createElement)(\\"h1\\", null, title));
}
}
var _default = FCComponent;
exports.default = _default;"
var _default = exports.default = FCComponent;"
`;

exports[`compiles typescript transpiles typescript code properly 1`] = `
Expand Down
30 changes: 0 additions & 30 deletions packages/babel-preset-default/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,36 +90,6 @@ describe('Babel preset default', () => {
});
});

describe('Babel preset default with automatic runtime', () => {
beforeEach(() => {
// fs.writeFileSync(path.join(reactPath, 'jsx-runtime.js'), 'export default () => {};');
});

afterEach(() => {
// fs.unlinkSync(path.join(reactPath, 'jsx-runtime.js'));
});

test('transpiles react code properly with automatic runtime', () => {
const output = babel.transform(reactInput, {
configFile: false,
envName: 'production',
presets: [babelPresetDefault],
});

expect(output.code).toMatchSnapshot();
});

test('transpiles wordpress code properly even when jsx-runtime.js is present', () => {
const output = babel.transform(reactInput, {
configFile: false,
envName: 'production',
presets: [[babelPresetDefault, { wordpress: true }]],
});

expect(output.code).toMatchSnapshot();
});
});

describe('compiles typescript', () => {
test('transpiles typescript code properly', () => {
const output = babel.transform(tsInput, {
Expand Down
3 changes: 2 additions & 1 deletion packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@10up/babel-preset-default": "^2.1.0"
},
"devDependencies": {
"@wordpress/eslint-plugin": "^14.9.0",
"eslint": "^8.40.0",
"prettier": "^2.4.1"
},
Expand All @@ -50,7 +51,7 @@
"peerDependencies": {
"@babel/core": "^7.21.4",
"@babel/eslint-parser": "^7.21.3",
"@wordpress/eslint-plugin": "^13.10.0",
"@wordpress/eslint-plugin": "^14.9.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is forcing react 18

"eslint": "^7.32.0 || ^8.0.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-base": "^15.0.0",
Expand Down
Loading
Loading