Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Stylelint to 15.0.0 #298

Merged
merged 15 commits into from
Oct 5, 2023
Merged

Updates Stylelint to 15.0.0 #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ae2fa30
Updates Stylelint to 15.0.0
Antonio-Laguna May 31, 2023
7f61b77
Picking up from .editorconfig
Antonio-Laguna May 31, 2023
f76b35f
Updating snapshot
Antonio-Laguna Jul 3, 2023
fe06890
Ensuring optional package is installed on dev
Antonio-Laguna Jul 3, 2023
faefae5
Merge branch 'develop' into feature/stylelint-upgrade
Antonio-Laguna Jul 20, 2023
d9246a6
Merge branch 'develop' into feature/stylelint-upgrade
Antonio-Laguna Aug 2, 2023
e7d6f97
Porting from #314
Antonio-Laguna Aug 2, 2023
5fe5d7e
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Sep 25, 2023
d5e6c59
update snapshots
nicholasio Sep 25, 2023
1d73345
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Sep 25, 2023
9def914
Migrating 10up-theme to React 18
Antonio-Laguna Oct 4, 2023
5ab6f90
Updating packages again
Antonio-Laguna Oct 4, 2023
760575f
Ensuring currentcolor works
Antonio-Laguna Oct 4, 2023
61b1575
Same import for all
Antonio-Laguna Oct 4, 2023
f68c04e
Merge branch 'develop' into feature/stylelint-upgrade
nicholasio Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/stylelint-config/scss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module.exports = {
extends: ['stylelint-config-standard-scss', './index.js'],
rules: {
'at-rule-no-unknown': null,
'import-notation': 'url',
'scss/at-rule-no-unknown': [true, { ignoreAtRules: ['mixin', 'define-mixin'] }],
},
};
2 changes: 1 addition & 1 deletion projects/10up-theme/assets/css/frontend/testing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Test comment
@import "./components/sass-component";
@import url("./components/sass-component.scss");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicholasio thoughts here? I think being consistent between scss and no scss is the way to go. Doesn't seem possible to have one linting rule just for scss rules so it's one or the other.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me!


.test-class {
color: var(--c-black);
Expand Down
Loading