Support externally-hashed keys #61
vlovichAnnotations
17 warnings
|
test (1.76.0)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test (1.76.0)
Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'working-directory', 'use-cross']
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L343
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:343:21
|
343 | n - (done_keys.len() as u64)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done_keys.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L423
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:423:16
|
423 | if done_keys.len() as u64 == n {
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `done_keys.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
benches/build.rs#L82
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> benches/build.rs:82:43
|
82 | std::hint::black_box(phf.hash(&i));
| ^^ help: change this to: `i`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L939
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:939:32
|
939 | let gt: Vec<u64> = (0..total as u64).collect();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L959
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:959:32
|
959 | let gt: Vec<u64> = (0..total as u64).collect();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L1066
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:1066:22
|
1066 | let gt = (0..total as u64).collect::<Vec<u64>>();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
test (1.66.0)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test (1.66.0)
Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'working-directory', 'use-cross']
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L246
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:246:9
|
246 | fastmod(fold(h), n as u32) as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fastmod(fold(h), n as u32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L343
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:343:21
|
343 | n - (done_keys.len() as u64)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done_keys.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L423
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:423:16
|
423 | if done_keys.len() as u64 == n {
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `done_keys.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L939
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:939:32
|
939 | let gt: Vec<u64> = (0..total as u64).collect();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L959
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:959:32
|
959 | let gt: Vec<u64> = (0..total as u64).collect();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
benches/build.rs#L82
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> benches/build.rs:82:43
|
82 | std::hint::black_box(phf.hash(&i));
| ^^ help: change this to: `i`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/lib.rs#L1066
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/lib.rs:1066:22
|
1066 | let gt = (0..total as u64).collect::<Vec<u64>>();
| ^^^^^^^^^^^^ help: try: `total`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|