-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Récupérer les inscriptions candidats après réconciliation (v3 uniquement) (PIX-14209) #10261
Merged
pix-service-auto-merge
merged 12 commits into
dev
from
pix-14209-get-v3-candidate-subscriptions
Oct 10, 2024
Merged
[FEATURE] Récupérer les inscriptions candidats après réconciliation (v3 uniquement) (PIX-14209) #10261
pix-service-auto-merge
merged 12 commits into
dev
from
pix-14209-get-v3-candidate-subscriptions
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
P-Jeremy
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
from
October 7, 2024 12:33
3986834
to
92f88be
Compare
Steph0
force-pushed
the
feat/pix-14207-check-eligibility-at-reconciliation
branch
2 times, most recently
from
October 8, 2024 08:27
323ee57
to
0ab6a39
Compare
P-Jeremy
force-pushed
the
feat/pix-14207-check-eligibility-at-reconciliation
branch
from
October 8, 2024 13:53
a2ce74a
to
0333cca
Compare
Steph0
force-pushed
the
feat/pix-14207-check-eligibility-at-reconciliation
branch
3 times, most recently
from
October 9, 2024 08:08
199ffb6
to
b8b2025
Compare
Base automatically changed from
feat/pix-14207-check-eligibility-at-reconciliation
to
dev
October 9, 2024 08:30
P-Jeremy
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
3 times, most recently
from
October 9, 2024 09:10
9598462
to
01b7e43
Compare
P-Jeremy
commented
Oct 9, 2024
mon-pix/tests/integration/components/certification-starter-test.js
Outdated
Show resolved
Hide resolved
P-Jeremy
commented
Oct 9, 2024
mon-pix/tests/integration/components/certification-starter-test.js
Outdated
Show resolved
Hide resolved
P-Jeremy
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
2 times, most recently
from
October 9, 2024 13:20
74d0fa7
to
d0871e6
Compare
alexandrecoin
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
3 times, most recently
from
October 9, 2024 15:47
0eb6ad5
to
c72ea6d
Compare
P-Jeremy
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
2 times, most recently
from
October 10, 2024 07:43
7edda70
to
0f82961
Compare
P-Jeremy
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
from
October 10, 2024 08:10
0f82961
to
f6fc107
Compare
P-Jeremy
added
👀 Tech Review Needed
Func Review OK
PO validated functionally the PR
labels
Oct 10, 2024
HEYGUL
reviewed
Oct 10, 2024
api/tests/certification/enrolment/acceptance/application/subscription-route_test.js
Outdated
Show resolved
Hide resolved
mcampourcy
reviewed
Oct 10, 2024
...ertification/enrolment/unit/domain/usecases/get-certification-candidate-subscription_test.js
Outdated
Show resolved
Hide resolved
HEYGUL
reviewed
Oct 10, 2024
HEYGUL
approved these changes
Oct 10, 2024
mcampourcy
approved these changes
Oct 10, 2024
Co-authored-by: Andreia Pena Ferreira <[email protected]> Co-authored-by: Guillaume LAGORCE <[email protected]>
Co-authored-by: Alexandre Coin <[email protected]>
Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
…ction Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
…mentary Co-authored-by: <[email protected]> Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-14209-get-v3-candidate-subscriptions
branch
from
October 10, 2024 12:49
ded25bf
to
74cc40a
Compare
pix-service-auto-merge
deleted the
pix-14209-get-v3-candidate-subscriptions
branch
October 10, 2024 12:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La route de réconciliation, /candidate-participation, vérifie désormais les conditions d'éligibilité du candidat. La route qui suit est un GET /subscriptions qui retourne les informations d’éligibilité pour le double bandeau dans la page “Code candidat”
En v2, ce route va calculer la validité des badges du candidats. Les badges non valides sont retournés pour que le bandeau jaune indique que le candidat s’est inscrit à une complémentaire mais n’est plus éligible.
On ne touche pas au comportement de la v2, en revanche il faut que le retour V2 et V3 soit iso pour le front.
🤖 Proposition
Est-ce que la session est V3 ?
NON, next
OUI, retourner ses subscriptions.
En V3, comme la route précédente s’est chargé de vérifier les conditions d’éligibilités, on va uniquement récupérer les subscriptions du candidat et les retourner au front.
Si cléA => on doit avoir 2 subscriptions et retourner le message “Vous êtes inscrit à la certification complémentaire suivante en plus de la certification Pix: CléA” (car double certification)
Si juste coeur => pas de bandeau
Si autres complémentaires => retourner le message “Vous êtes inscrit à la certification complémentaire suivante : certif complémentaire”
🌈 Remarques
💯 Pour tester