[FEATURE] Ajouter la bannière de la nouvelle page de fin de parcours (PIX-12987). #10230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
Development in progress
team-evaluation
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
from
7580547
to
e800a05
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
4 times, most recently
from
3a633ba
to
79503fc
Compare
Jeyffrey
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
2 times, most recently
from
594ae6f
to
89a1ff0
Compare
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
7 times, most recently
from
aeb890c
to
a6e1969
Compare
mon-pix/app/components/campaigns/assessment/skill-review/evaluation-results-hero/index.gjs
Outdated
Show resolved
Hide resolved
...omponents/campaigns/assessment/skill-review/evaluation-results-hero/retry-or-reset-block.gjs
Outdated
Show resolved
Hide resolved
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
2 times, most recently
from
b1630c6
to
29d583d
Compare
...ntegration/components/campaigns/assessment/skill-review/hero/evaluation-results-hero-test.js
Outdated
Show resolved
Hide resolved
Comment on lines
+25
to
+37
| acquired: this.args.campaignParticipationResult.reachedStage.reachedStage - 1, | ||
| total: this.args.campaignParticipationResult.reachedStage.totalStage - 1, |
There was a problem hiding this comment.
refacto à faire dans un autre ticket pour faire :
- le calcul côté back
- renommer reachedStage.reachedStage en quelque chose de plus cohérent
mon-pix/app/components/campaigns/assessment/skill-review/evaluation-results-hero/index.gjs
Show resolved
Hide resolved
| @@ -22,14 +22,11 @@ module('Integration | Components | Campaigns | Assessment | Skill Review | Evalu | |||
|
|
|||
| this.owner.register('service:currentUser', currentUserService); | |||
|
|
|||
| this.set('campaignParticipationResult', { masteryRate: 0.755 }); | |||
| this.set('campaignParticipationResult', { masteryRate: 0.75 }); | |||
There was a problem hiding this comment.
A faire dans un autre ticket. Arrondir le pourcentage côté api et non côté front.
...ntegration/components/campaigns/assessment/skill-review/hero/evaluation-results-hero-test.js
Show resolved
Hide resolved
Libouk
reviewed
Oct 8, 2024
...ntegration/components/campaigns/assessment/skill-review/hero/evaluation-results-hero-test.js
Show resolved
Hide resolved
Libouk
reviewed
Oct 8, 2024
...ntegration/components/campaigns/assessment/skill-review/hero/evaluation-results-hero-test.js
Outdated
Show resolved
Hide resolved
Libouk
reviewed
Oct 8, 2024
mon-pix/tests/integration/components/routes/campaigns/assessment/evaluation-results-test.js
Outdated
Show resolved
Hide resolved
Libouk
reviewed
Oct 8, 2024
...ntegration/components/campaigns/assessment/skill-review/hero/evaluation-results-hero-test.js
Show resolved
Hide resolved
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
9 times, most recently
from
2e1f441
to
3a8ca6d
Compare
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
from
3a8ca6d
to
155791b
Compare
Jeyffrey
force-pushed
the
pix-12987-new-evaluation-results-hero
branch
from
155791b
to
4067f14
Compare
|
Etrange que l'utilisateur ait obtenu 5 étoiles ici. Est ce un bug ou bien les paliers qui sont paramétrés ainsi?
|
|
Questions pour le design :
|
|
|
j'ai ajouté d'autres commentaire de review directement sur le fichier ici : https://www.figma.com/design/tlukMJuPbw6yec01fWDCuV/App---Rdy-Dev?node-id=11321-1342&t=sSMbYrkwKFViMhQV-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans le nouvel écran de fin de parcours, il manque la bannière.
🤖 Proposition
Voir tous les cas d'affichage dans le ticket (trop de cas à lister ici).
💯 Pour tester
[email protected][email protected][email protected]