-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rendre autonome le métier pour gérer la liste blanche des centres de certification fermés. #10176
Conversation
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
admin/app/components/administration/certification/sco-whitelist-configuration.gjs
Show resolved
Hide resolved
...ertification/configuration/integration/infrastructure/repositories/center-repository_test.js
Show resolved
Hide resolved
admin/app/components/administration/certification/sco-whitelist-configuration.gjs
Outdated
Show resolved
Hide resolved
api/src/certification/configuration/application/sco-whitelist-route.js
Outdated
Show resolved
Hide resolved
admin/app/components/administration/certification/sco-whitelist-configuration.gjs
Outdated
Show resolved
Hide resolved
7267b03
to
627c10d
Compare
627c10d
to
0076397
Compare
admin/app/components/administration/certification/sco-whitelist-configuration.gjs
Outdated
Show resolved
Hide resolved
admin/app/components/administration/certification/sco-whitelist-configuration.gjs
Outdated
Show resolved
Hide resolved
pre: [ | ||
{ | ||
method: (request, h) => | ||
securityPreHandlers.hasAtLeastOneAccessOf([securityPreHandlers.checkAdminMemberHasRoleSuperAdmin])( | ||
request, | ||
h, | ||
), | ||
assign: 'hasAuthorizationToAccessAdminScope', | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre: [ | |
{ | |
method: (request, h) => | |
securityPreHandlers.hasAtLeastOneAccessOf([securityPreHandlers.checkAdminMemberHasRoleSuperAdmin])( | |
request, | |
h, | |
), | |
assign: 'hasAuthorizationToAccessAdminScope', | |
}, | |
], | |
pre: [ | |
{ | |
method: securityPreHandlers.checkAdminMemberHasRoleSuperAdmin, | |
assign: 'hasAuthorizationToAccessAdminScope', | |
}, | |
], |
api/src/certification/configuration/application/sco-whitelist-route.js
Outdated
Show resolved
Hide resolved
api/src/certification/configuration/infrastructure/repositories/center-repository.js
Outdated
Show resolved
Hide resolved
0076397
to
0876350
Compare
test('it displays a success notification', async function (assert) { | ||
// when | ||
const screen = await render(<template><ScoWhitelistConfiguration /><NotificationContainer /></template>); | ||
const input = await screen.getByLabelText(t('pages.administration.certification.sco-whitelist.import.button')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
les get n'ont pas besoin d'await, ils ne retournent pas de promise. Les find oui.
const input = await screen.getByLabelText(t('pages.administration.certification.sco-whitelist.import.button')); | |
const input = screen.getByLabelText(t('pages.administration.certification.sco-whitelist.import.button')); |
tags: ['api', 'admin'], | ||
notes: [ | ||
'Cette route est restreinte aux utilisateurs authentifiés avec le rôle Super Admin', | ||
'Elle permet de mettre a jour la liste blanche des centres SCO.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Elle permet de mettre a jour la liste blanche des centres SCO.', | |
'Elle permet de mettre à jour la liste blanche des centres SCO.', |
const certificationConfigurationRoutes = [complementaryCertification]; | ||
const scoWhitelistRoutes = [scoWhitelist]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elle devrait pas être là plutôt?
const certificationConfigurationRoutes = [complementaryCertification]; | |
const scoWhitelistRoutes = [scoWhitelist]; | |
const certificationConfigurationRoutes = [complementaryCertification, scoWhitelist]; |
Co-authored-by: P-Jeremy < [email protected]>
Co-authored-by: P-Jeremy < [email protected]>
Co-authored-by: P-Jeremy < [email protected]>
0876350
to
45d452f
Compare
🦄 Problème
La liste blanche des centres SCO est
🤖 Proposition
Exemple de contenu de fichier CSV valide
🌈 Remarques
IMPORTANT
Pour vous eviter des PR a +1K de lignes, on decoupe un peu, et donc c'est ici une premiere partie stable, c'est a dire
Les etapes suivantes seront
pixCertifScoBlockedAccessWhitelist
, deja quelques centaines de lignes en +pixCertifScoBlockedAccessWhitelist
💯 Pour tester