[TECH] Permettre la suppression de cronJob lorsque l'on change son nom (PIX-14453) #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xav-car
force-pushed
the
pix-job-cron-update
branch
from
7e71aea
to
4e38fcf
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-job-cron-update
branch
2 times, most recently
from
3427c01
to
7726c4f
Compare
xav-car
changed the title
xav-car
added
Development in progress
tech-days-evenementiel
xav-car
force-pushed
the
pix-job-cron-update
branch
from
e5bd0ea
to
bb194ba
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
team-captains
lionelB
reviewed
Sep 24, 2024
...nt/application/jobs/schedule-compute-organization-learners-certificability-job-controller.js
Show resolved
Hide resolved
lionelB
reviewed
Sep 24, 2024
...plication/jobs/schedule-compute-organization-learners-certificability-job-controller_test.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Sep 24, 2024
lionelB
reviewed
Sep 24, 2024
...nt/application/jobs/schedule-compute-organization-learners-certificability-job-controller.js
Show resolved
Hide resolved
xav-car
force-pushed
the
pix-job-cron-update
branch
2 times, most recently
from
9987ee5
to
44df576
Compare
lionelB
approved these changes
Sep 24, 2024
xav-car
force-pushed
the
pix-job-cron-update
branch
2 times, most recently
from
bc669fd
to
db95d12
Compare
xav-car
added
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
force-pushed
the
pix-job-cron-update
branch
2 times, most recently
from
0c1d77e
to
97bb7a3
Compare
pix-service-auto-merge
force-pushed
the
pix-job-cron-update
branch
from
97bb7a3
to
eaf1474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lors des Tech Days Evenementiel, nous avons introduit un petit changement de nom dans le job de calcul de la certificabilité auto. Ce qui nous a permis de voir qu'une table pgboss.schedule enregistré les job a executé.
🤖 Proposition
Utiliser le nom en cohérence avec le controller associé. Ajouter un legacyName dans les cronJob si l'on souhaite nettoyer un ancien nom.
Il y aura certainement un autre cas à gérer dans le cas de la suppression d'un cron job afin que celui ci soit pris en compte.
🌈 Remarques
RAS
💯 Pour tester
Ajouter l'ancien nom dans la table pgboss.schedule .
Vérifier que la table pg.boss ne contient plus l'ancien job
ComputeOrganizationLearnersCertificabilityau restart du container ( sur les RA le worker est sur la même instance que l'api )