✨ api: unschedule old cron job when disabled

1024pix · Oct 4, 2024 · da95a1d · da95a1d
1 parent dfcb3c9
commit da95a1d
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/api/src/shared/config.js b/api/src/shared/config.js
@@ -492,6 +492,7 @@ const configuration = (function () {
 
     config.cpf.sendEmailJob = {
       recipient: '[email protected]',
+      cron: '0 3 * * *',
     };
 
     config.jwtConfig.livretScolaire = { secret: 'secretosmose', tokenLifespan: '1h' };

diff --git a/api/tests/unit/worker_test.js b/api/tests/unit/worker_test.js
@@ -157,5 +157,24 @@ describe('#registerJobs', function () {
         'legyNameForScheduleComputeOrganizationLearnersCertificabilityJobController',
       );
     });
+
+    context('when a cron job is disabled', function () {
+      it('unschedule the job', async function () {
+        //given
+        sinon.stub(config.cpf.sendEmailJob, 'cron').value('0 21 * * *');
+        sinon.stub(config.pgBoss, 'exportSenderJobEnabled').value(false);
+
+        await registerJobs({
+          jobGroup: JobGroup.DEFAULT,
+          dependencies: {
+            startPgBoss: startPgBossStub,
+            createJobQueues: createJobQueuesStub,
+          },
+        });
+
+        // then
+        expect(jobQueueStub.unscheduleCronJob).to.have.been.calledWithExactly('CpfExportSenderJob');
+      });
+    });
   });
 });
diff --git a/api/worker.js b/api/worker.js
@@ -113,6 +113,12 @@ export async function registerJobs({ jobGroup, dependencies = { startPgBoss, cre
       }
     } else {
       logger.warn(`Job "${job.jobName}" is disabled.`);
+
+      // For cronJob we need to unschedule older cron
+      if (job.jobCron) {
+        await jobQueues.unscheduleCronJob(job.jobName);
+        logger.info(`Job CRON "${job.jobName}" is unscheduled.`);
+      }
     }
   }