🚧 mon-pix: use pix companion feature toggle in pix app

1024pix · Oct 10, 2024 · 4757b9b · 4757b9b
1 parent 93072f7
commit 4757b9b
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 30 deletions.
diff --git a/mon-pix/app/models/feature-toggle.js b/mon-pix/app/models/feature-toggle.js
@@ -4,4 +4,5 @@ export default class FeatureToggle extends Model {
   @attr('boolean') isNewAuthenticationDesignEnabled;
   @attr('boolean') isTextToSpeechButtonEnabled;
   @attr('boolean') showNewResultPage;
+  @attr('boolean') isPixCompanionEnabled;
 }
diff --git a/mon-pix/app/services/pix-companion.js b/mon-pix/app/services/pix-companion.js
@@ -1,8 +1,8 @@
-import Service from '@ember/service';
+import Service, { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
-import ENV from 'mon-pix/config/environment';
 
 export default class PixCompanion extends Service {
+  @service featureToggles;
   @tracked _isExtensionEnabled = true;
 
   #checkExtensionIsEnabledInterval;
@@ -18,13 +18,13 @@ export default class PixCompanion extends Service {
   }
 
   startCheckingExtensionIsEnabled(windowRef = window) {
-    if (!ENV.APP.FT_IS_PIX_COMPANION_MANDATORY) return;
+    if (!this.featureToggles.isPixCompanionEnabled) return;
     this.checkExtensionIsEnabled(windowRef);
     this.#checkExtensionIsEnabledInterval = windowRef.setInterval(() => this.checkExtensionIsEnabled(windowRef), 1000);
   }
 
   stopCheckingExtensionIsEnabled(windowRef = window) {
-    if (!ENV.APP.FT_IS_PIX_COMPANION_MANDATORY) return;
+    if (!this.featureToggles.isPixCompanionEnabled) return;
     windowRef.clearInterval(this.#checkExtensionIsEnabledInterval);
   }
 
@@ -50,7 +50,7 @@ export default class PixCompanion extends Service {
   }
 
   get isExtensionEnabled() {
-    if (!ENV.APP.FT_IS_PIX_COMPANION_MANDATORY) return true;
+    if (!this.featureToggles.isPixCompanionEnabled) return true;
     return this._isExtensionEnabled;
   }
 }

diff --git a/mon-pix/config/environment.js b/mon-pix/config/environment.js
@@ -43,7 +43,6 @@ module.exports = function (environment) {
       // when it is created
       API_HOST: process.env.API_HOST || '',
       FT_FOCUS_CHALLENGE_ENABLED: _isFeatureEnabled(process.env.FT_FOCUS_CHALLENGE_ENABLED) || false,
-      FT_IS_PIX_COMPANION_MANDATORY: _isFeatureEnabled(process.env.FT_IS_PIX_COMPANION_MANDATORY) || false,
       isTimerCountdownEnabled: true,
       LOAD_EXTERNAL_SCRIPT: true,
       NUMBER_OF_CHALLENGES_BETWEEN_TWO_CHECKPOINTS: 5,
@@ -172,7 +171,6 @@ module.exports = function (environment) {
     ENV.APP.isTimerCountdownEnabled = false;
     ENV.APP.LOAD_EXTERNAL_SCRIPT = false;
     ENV.APP.FT_FOCUS_CHALLENGE_ENABLED = true;
-    ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = false;
     ENV.APP.AUTONOMOUS_COURSES_ORGANIZATION_ID = 999;
     ENV.metrics.enabled = false;
   }

diff --git a/mon-pix/tests/unit/services/feature-toggles-test.js b/mon-pix/tests/unit/services/feature-toggles-test.js
@@ -11,6 +11,7 @@ module('Unit | Service | feature-toggles', function (hooks) {
     const featureToggles = Object.create({
       isTextToSpeechButtonEnabled: false,
       isNewAuthenticationDesignEnabled: false,
+      isPixCompanionEnabled: false,
     });
 
     let storeStub;
@@ -45,7 +46,7 @@ module('Unit | Service | feature-toggles', function (hooks) {
       assert.false(featureToggleService.featureToggles.isTextToSpeechButtonEnabled);
     });
 
-    test('it initializes the feature toggle isNewAuthenticationDesignEnabled to true', async function (assert) {
+    test('it initializes the feature toggle isNewAuthenticationDesignEnabled to false', async function (assert) {
       // given
       const featureToggleService = this.owner.lookup('service:featureToggles');
       featureToggleService.set('store', storeStub);
@@ -56,5 +57,17 @@ module('Unit | Service | feature-toggles', function (hooks) {
       // then
       assert.false(featureToggleService.featureToggles.isNewAuthenticationDesignEnabled);
     });
+
+    test('it initializes the feature toggle isPixCompanionEnabled to false', async function (assert) {
+      // given
+      const featureToggleService = this.owner.lookup('service:featureToggles');
+      featureToggleService.set('store', storeStub);
+
+      // when
+      await featureToggleService.load();
+
+      // then
+      assert.false(featureToggleService.featureToggles.isPixCompanionEnabled);
+    });
   });
 });
diff --git a/mon-pix/tests/unit/services/pix-companion-test.js b/mon-pix/tests/unit/services/pix-companion-test.js
@@ -1,19 +1,14 @@
 import { setupTest } from 'ember-qunit';
-import ENV from 'mon-pix/config/environment';
 import { module, test } from 'qunit';
 import sinon from 'sinon';
 
 module('Unit | Service | pix-companion', function (hooks) {
   setupTest(hooks);
+  let pixCompanion;
 
-  const ORIGINAL_FT_IS_PIX_COMPANION_MANDATORY = ENV.APP.FT_IS_PIX_COMPANION_MANDATORY;
-
-  hooks.beforeEach(() => {
-    ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = true;
-  });
-
-  hooks.afterEach(() => {
-    ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = ORIGINAL_FT_IS_PIX_COMPANION_MANDATORY;
+  hooks.beforeEach(function () {
+    pixCompanion = this.owner.lookup('service:pix-companion');
+    pixCompanion.featureToggles = { isPixCompanionEnabled: true };
   });
 
   module('#startCertification', function () {
@@ -24,7 +19,6 @@ module('Unit | Service | pix-companion', function (hooks) {
         postMessage: sinon.stub(),
         location: { origin: 'test' },
       };
-      const pixCompanion = this.owner.lookup('service:pix-companion');
 
       // When
       pixCompanion.startCertification(windowStub);
@@ -44,7 +38,6 @@ module('Unit | Service | pix-companion', function (hooks) {
         postMessage: sinon.stub(),
         location: { origin: 'test' },
       };
-      const pixCompanion = this.owner.lookup('service:pix-companion');
 
       // When
       pixCompanion.stopCertification(windowStub);
@@ -69,7 +62,6 @@ module('Unit | Service | pix-companion', function (hooks) {
         assert.strictEqual(type, 'pix:companion:pong');
         listener();
       });
-      const pixCompanion = this.owner.lookup('service:pix-companion');
       pixCompanion._isExtensionEnabled = false;
 
       // When
@@ -93,7 +85,6 @@ module('Unit | Service | pix-companion', function (hooks) {
         assert.strictEqual(timeout, 100);
         callback();
       });
-      const pixCompanion = this.owner.lookup('service:pix-companion');
       pixCompanion._isExtensionEnabled = true;
 
       // When
@@ -107,18 +98,17 @@ module('Unit | Service | pix-companion', function (hooks) {
   });
 
   module('#startCheckingExtensionIsEnabled', function () {
-    module('when FT_IS_PIX_COMPANION_MANDATORY is false', function () {
+    module('when the feature toggle isPixCompanionEnabled is false', function () {
       test('do nothing', async function (assert) {
         // Given
-        ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = false;
         const windowStub = {
           addEventListener: sinon.stub(),
           dispatchEvent: sinon.stub(),
           removeEventListener: sinon.stub(),
           setInterval: sinon.stub(),
           setTimeout: sinon.stub(),
         };
-        const pixCompanion = this.owner.lookup('service:pix-companion');
+        pixCompanion.featureToggles = { isPixCompanionEnabled: false };
 
         // When
         pixCompanion.startCheckingExtensionIsEnabled(windowStub);
@@ -136,14 +126,13 @@ module('Unit | Service | pix-companion', function (hooks) {
   });
 
   module('#stopCheckingExtensionIsEnabled', function () {
-    module('when FT_IS_PIX_COMPANION_MANDATORY is false', function () {
+    module('when the feature toggle isPixCompanionEnabled is false', function () {
       test('do nothing', async function (assert) {
         // Given
-        ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = false;
         const windowStub = {
           clearInterval: sinon.stub(),
         };
-        const pixCompanion = this.owner.lookup('service:pix-companion');
+        pixCompanion.featureToggles = { isPixCompanionEnabled: false };
 
         // When
         pixCompanion.stopCheckingExtensionIsEnabled(windowStub);
@@ -156,11 +145,10 @@ module('Unit | Service | pix-companion', function (hooks) {
   });
 
   module('#isExtensionEnabled', function () {
-    module('when FT_IS_PIX_COMPANION_MANDATORY is false', function () {
+    module('when the feature toggle isPixCompanionEnabled is false', function () {
       test('always return true', async function (assert) {
         // Given
-        ENV.APP.FT_IS_PIX_COMPANION_MANDATORY = false;
-        const pixCompanion = this.owner.lookup('service:pix-companion');
+        pixCompanion.featureToggles = { isPixCompanionEnabled: false };
 
         // When
         pixCompanion._isExtensionEnabled = false;