[TECH] Utiliser un service plutot que passer par le model pour synchroniser les traductions (PIX-14629) #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Iris Benoit <[email protected]> Co-authored-by: Fael Bassetti <[email protected]> Co-authored-by: Laura Bergoens <[email protected]>
|
Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr771.osc-fr1.scalingo.io |
Jeremiejade
added
👀 Func Review Needed
team-contenu
Co-authored-by: Iris Benoit <[email protected]> Co-authored-by: Fael Bassetti <[email protected]> Co-authored-by: Laura Bergoens <[email protected]>
Jeremiejade
force-pushed
the
pix-14629-use-service-for-download-translations
branch
from
163b6a4
to
6cc33b0
Compare
laura-bergoens
approved these changes
Oct 2, 2024
laura-bergoens
changed the title
fael-b
approved these changes
Oct 2, 2024
Jeremiejade
added
Func Review OK
🚀 Ready to Merge
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
pix-service-auto-merge
deleted the
pix-14629-use-service-for-download-translations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Nous détournions l'usage d'ember data pour récupérer les traductions via phrase.
🤖 Proposition
utiliser un service.
🌈 Remarques
Nous supprimons la librairie utilisée dans une autre PR.
💯 Pour tester
Se rendre sur la page de synchronisation des traductions et vérifier que tout se passe bien.