✨ feat: add card image url to mission

1024pix · Oct 4, 2024 · 71fcf34 · 71fcf34
1 parent 668446b
commit 71fcf34
Show file tree

Hide file tree

Showing 25 changed files with 115 additions and 3 deletions.
diff --git a/api/db/migrations/20241004083929_add-card-image-to-mission.js b/api/db/migrations/20241004083929_add-card-image-to-mission.js
@@ -0,0 +1,21 @@
+const TABLE_NAME = 'missions';
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export async function up(knex) {
+  await knex.schema.alterTable(TABLE_NAME, function(table) {
+    table.string('cardImageUrl').nullable();
+  });
+}
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export async function down(knex) {
+  await knex.schema.alterTable(TABLE_NAME, function(table) {
+    table.dropColumn('cardImageUrl');
+  });
+}
diff --git a/api/db/seeds/data/missions.js b/api/db/seeds/data/missions.js
@@ -3,6 +3,7 @@ import { Mission } from '../../../lib/domain/models/Mission.js';
 export function buildMissions(databaseBuilder) {
   databaseBuilder.factory.buildMission({
     name: 'Mission test active',
+    cardImageUrl: 'https://example.net/image.png',
     competenceId: 'competence1NC9NE3IIOa0ym',
     learningObjectives: 'Que tu sois le meilleur',
     thematicIds: 'recOO8OsMJpe5cZzi,recOO8OsMJpe5cZzi',
@@ -13,6 +14,7 @@ export function buildMissions(databaseBuilder) {
 
   databaseBuilder.factory.buildMission({
     name: 'Mission test inactive',
+    cardImageUrl: 'https://example.net/image.png',
     competenceId: 'competence2k2eVZ2GRLwqFL',
     learningObjectives: 'Y\'en a plus',
     thematicIds: 'rec98EBX88mkQR3gx,rec98EBX88mkQR3gx',
@@ -22,6 +24,7 @@ export function buildMissions(databaseBuilder) {
   });
   databaseBuilder.factory.buildMission({
     name: 'Mission test inactive',
+    cardImageUrl: 'https://example.net/image.png',
     competenceId: 'competence1NC9NE3IIOa0ym',
     learningObjectives: 'Y\'en a plus',
     thematicIds: 'recOO8OsMJpe5cZzi,recj6ITlVfU0vByrR,recRSPkFIgrY6Ps61',
@@ -31,6 +34,7 @@ export function buildMissions(databaseBuilder) {
   });
   databaseBuilder.factory.buildMission({
     name: 'Mission test expérimentale',
+    cardImageUrl: 'https://example.net/image.png',
     competenceId: 'competence1NC9NE3IIOa0ym',
     learningObjectives: 'Y\'en a plus',
     thematicIds: 'recOO8OsMJpe5cZzi,recj6ITlVfU0vByrR,recRSPkFIgrY6Ps61',

diff --git a/api/lib/domain/models/Mission.js b/api/lib/domain/models/Mission.js
@@ -2,6 +2,7 @@ export class Mission {
   constructor({
     id,
     name_i18n,
+    cardImageUrl,
     competenceId,
     thematicIds,
     createdAt,
@@ -15,6 +16,7 @@ export class Mission {
   }) {
     this.id = id;
     this.name_i18n = name_i18n;
+    this.cardImageUrl = cardImageUrl;
     this.competenceId = competenceId;
     this.thematicIds = thematicIds;
     this.createdAt = createdAt;

diff --git a/api/lib/domain/models/release/MissionForRelease.js b/api/lib/domain/models/release/MissionForRelease.js
@@ -2,6 +2,7 @@ export class MissionForRelease {
   constructor({
     id,
     name_i18n,
+    cardImageUrl,
     competenceId,
     learningObjectives_i18n,
     validatedObjectives_i18n,
@@ -14,6 +15,7 @@ export class MissionForRelease {
   }) {
     this.id = id;
     this.name_i18n = name_i18n;
+    this.cardImageUrl = cardImageUrl;
     this.competenceId = competenceId;
     this.learningObjectives_i18n = learningObjectives_i18n;
     this.validatedObjectives_i18n = validatedObjectives_i18n;

diff --git a/api/lib/infrastructure/repositories/mission-repository.js b/api/lib/infrastructure/repositories/mission-repository.js
@@ -49,6 +49,7 @@ export async function listActive() {
 export async function save(mission) {
   const [insertedMission] = await knex('missions').insert({
     id: mission.id,
+    cardImageUrl: mission.cardImageUrl,
     competenceId: mission.competenceId,
     thematicIds: mission.thematicIds,
     status: mission.status,
@@ -69,6 +70,7 @@ function _toDomain(mission, translations) {
   const translationsByMissionId = _.groupBy(translations, 'entityId');
   return new Mission({
     id: mission.id,
+    cardImageUrl: mission.cardImageUrl,
     createdAt: mission.createdAt,
     status: mission.status,
     competenceId: mission.competenceId,

diff --git a/api/lib/infrastructure/serializers/jsonapi/mission-serializer.js b/api/lib/infrastructure/serializers/jsonapi/mission-serializer.js
@@ -31,6 +31,7 @@ export function serializeMission(mission, warnings) {
     },
     attributes: [
       'name',
+      'cardImageUrl',
       'competenceId',
       'thematicIds',
       'learningObjectives',
@@ -51,6 +52,7 @@ export function deserializeMission(attributes) {
   return new Mission({
     id: attributes.id,
     name_i18n: { fr: attributes.name  },
+    cardImageUrl: attributes['card-image-url'] || null,
     competenceId: attributes['competence-id'],
     thematicIds: attributes['thematic-ids'],
     learningObjectives_i18n:  { fr:  attributes['learning-objectives'] },

diff --git a/api/tests/acceptance/application/mission/get_mission_test.js b/api/tests/acceptance/application/mission/get_mission_test.js
@@ -18,7 +18,7 @@ describe('Acceptance | API | mission | GET /api/missions', function() {
 
     //given
     const user = databaseBuilder.factory.buildAdminUser();
-    const mission = databaseBuilder.factory.buildMission({ name: 'Condor', status: Mission.status.VALIDATED, competenceId: 'recCompetence0', thematicIds: null, validatedObjectives: 'Être forte', learningObjectives: 'Être imbattable', createdAt: new Date('2024-01-01') });
+    const mission = databaseBuilder.factory.buildMission({ name: 'Condor', cardImageUrl: 'https://example.com/image.png', status: Mission.status.VALIDATED, competenceId: 'recCompetence0', thematicIds: null, validatedObjectives: 'Être forte', learningObjectives: 'Être imbattable', createdAt: new Date('2024-01-01') });
     await databaseBuilder.commit();
 
     //when
@@ -36,6 +36,7 @@ describe('Acceptance | API | mission | GET /api/missions', function() {
         id: mission.id.toString(),
         attributes: {
           name: 'Condor',
+          'card-image-url': 'https://example.com/image.png',
           status: Mission.status.VALIDATED,
           'competence-id': 'recCompetence0',
           'thematic-ids': null,

diff --git a/api/tests/acceptance/application/mission/post_mission_test.js b/api/tests/acceptance/application/mission/post_mission_test.js
@@ -25,6 +25,7 @@ describe('Acceptance | API | mission | POST /api/missions', function() {
         data: {
           attributes: {
             name: 'Mission impossible',
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'AZERTY',
             'thematic-id': null,
             status: Mission.status.INACTIVE,
@@ -52,6 +53,7 @@ describe('Acceptance | API | mission | POST /api/missions', function() {
           type: 'missions',
           id: missionId.toString(),
           'attributes': {
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'AZERTY',
             'documentation-url': null,
             'introduction-media-alt': null,
@@ -79,6 +81,7 @@ describe('Acceptance | API | mission | POST /api/missions', function() {
         data: {
           attributes: {
             name: 'Mission impossible',
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'AZERTY',
             'thematic-id': null,
             status: Mission.status.INACTIVE,

diff --git a/api/tests/acceptance/application/mission/put_mission_test.js b/api/tests/acceptance/application/mission/put_mission_test.js
@@ -26,6 +26,7 @@ describe('Acceptance | API | mission | PATCH /api/missions/{id}', function() {
         data: {
           attributes: {
             name: 'Mission à mettre à jour',
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'TYUI',
             'thematic-ids': '',
             status: Mission.status.EXPERIMENTAL,
@@ -54,6 +55,7 @@ describe('Acceptance | API | mission | PATCH /api/missions/{id}', function() {
           type: 'missions',
           id: missionId.toString(),
           'attributes': {
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'TYUI',
             'documentation-url': null,
             'introduction-media-alt': null,
@@ -82,6 +84,7 @@ describe('Acceptance | API | mission | PATCH /api/missions/{id}', function() {
         data: {
           attributes: {
             name: 'Mission impossible',
+            'card-image-url': 'https://example.com/image.png',
             'competence-id': 'AZERTY',
             'thematic-id': null,
             status: Mission.status.INACTIVE,

diff --git a/api/tests/acceptance/application/releases/releases-controller_test.js b/api/tests/acceptance/application/releases/releases-controller_test.js
@@ -156,6 +156,7 @@ async function mockCurrentContent() {
     missions: [{
       id: 1,
       name_i18n: { fr: 'Ma première mission' },
+      cardImageUrl: 'https://example.com/image0.png',
       competenceId: 'competenceId',
       thematicIds: 'thematicId,thematicId',
       learningObjectives_i18n: { fr: 'Que tu sois le meilleur' },
@@ -173,6 +174,7 @@ async function mockCurrentContent() {
     }, {
       id: 2,
       name_i18n: { fr: 'Alt name' },
+      cardImageUrl: 'https://example.com/image1.png',
       competenceId: 'competenceId',
       thematicIds: 'thematicId,thematicId',
       learningObjectives_i18n: { fr: 'Alt objectives' },
@@ -236,6 +238,7 @@ async function mockCurrentContent() {
   databaseBuilder.factory.buildMission({
     id: 1,
     name: 'Ma première mission',
+    cardImageUrl: 'https://example.com/image0.png',
     competenceId: 'competenceId',
     thematicIds: 'thematicId,thematicId',
     learningObjectives: 'Que tu sois le meilleur',
@@ -249,6 +252,7 @@ async function mockCurrentContent() {
   databaseBuilder.factory.buildMission({
     id: 2,
     name: 'Alt name',
+    cardImageUrl: 'https://example.com/image1.png',
     competenceId: 'competenceId',
     thematicIds: 'thematicId,thematicId',
     learningObjectives: 'Alt objectives',
@@ -262,6 +266,7 @@ async function mockCurrentContent() {
   databaseBuilder.factory.buildMission({
     id: 3,
     name: 'Alt name',
+    cardImageUrl: 'https://example.com/image2.png',
     competenceId: 'competenceId',
     thematicIds: 'thematicId,thematicId',
     learningObjectives: 'Alt objectives',
@@ -500,6 +505,7 @@ async function mockContentForRelease() {
     missions: [new MissionForRelease({
       id: 1,
       name_i18n: { fr: 'Ma première mission' },
+      cardImageUrl: 'https://example.com/image2.png',
       competenceId: 'competenceId',
       learningObjectives_i18n: { fr: 'Que tu sois le meilleur' },
       validatedObjectives_i18n: { fr: 'Rien' },
@@ -511,6 +517,7 @@ async function mockContentForRelease() {
     }), new MissionForRelease({
       id: 2,
       name_i18n: { fr: 'Alt name' },
+      cardImageUrl: 'https://example.com/image2.png',
       competenceId: 'competenceId',
       learningObjectives_i18n: { fr: 'Alt objectives' },
       validatedObjectives_i18n: { fr: 'Alt validated objectives' },
@@ -779,6 +786,7 @@ describe('Acceptance | Controller | release-controller', () => {
         databaseBuilder.factory.buildMission({
           id: 1,
           name: 'Ma première mission',
+          cardImageUrl: 'https://example.com/image2.png',
           competenceId: 'competenceId',
           thematicIds: 'thematicId,thematicId',
           learningObjectives: 'Que tu sois le meilleur',
@@ -792,6 +800,7 @@ describe('Acceptance | Controller | release-controller', () => {
         databaseBuilder.factory.buildMission({
           id: 2,
           name: 'Alt name',
+          cardImageUrl: 'https://example.com/image2.png',
           competenceId: 'competenceId',
           thematicIds: 'thematicId,thematicId',
           learningObjectives: 'Alt objectives',
@@ -805,6 +814,7 @@ describe('Acceptance | Controller | release-controller', () => {
         databaseBuilder.factory.buildMission({
           id: 3,
           name: 'Alt name',
+          cardImageUrl: 'https://example.com/image2.png',
           competenceId: 'competenceId',
           thematicIds: 'thematicId,thematicId',
           learningObjectives: 'Alt objectives',

diff --git a/api/tests/integration/infrastructure/repositories/mission-repository_test.js b/api/tests/integration/infrastructure/repositories/mission-repository_test.js
@@ -34,6 +34,7 @@ describe('Integration | Repository | mission-repository', function() {
         expect(result).to.deep.equal(new Mission({
           id: 1,
           name_i18n: { fr: 'Ma première mission' },
+          cardImageUrl: null,
           competenceId: 'competenceId',
           thematicIds: 'thematicIds',
           learningObjectives_i18n: { fr: 'Que tu sois le meilleur' },
@@ -51,9 +52,10 @@ describe('Integration | Repository | mission-repository', function() {
   describe('#findAllMissions', function() {
     context('When there are missions', function() {
       it('should return all missions', async function() {
-        databaseBuilder.factory.buildMission({ id: 1, status: Mission.status.VALIDATED });
+        databaseBuilder.factory.buildMission({ id: 1, cardImageUrl: null, status: Mission.status.VALIDATED });
         databaseBuilder.factory.buildMission({
           id: 2,
+          cardImageUrl: 'https://images.pix.fr/mission-card-image.png',
           name: 'Alt name',
           status: Mission.status.INACTIVE,
           learningObjectives: 'Alt objectives',
@@ -65,6 +67,7 @@ describe('Integration | Repository | mission-repository', function() {
 
         expect(results.missions).to.deep.equal([new Mission({
           id: 1,
+          cardImageUrl: null,
           name_i18n: { fr: 'Ma première mission' },
           competenceId: 'competenceId',
           thematicIds: 'thematicIds',
@@ -78,6 +81,7 @@ describe('Integration | Repository | mission-repository', function() {
           createdAt: new Date('2010-01-04'),
         }), new Mission({
           id: 2,
+          cardImageUrl: 'https://images.pix.fr/mission-card-image.png',
           name_i18n: { fr: 'Alt name' },
           competenceId: 'competenceId',
           thematicIds: 'thematicIds',
@@ -156,6 +160,7 @@ describe('Integration | Repository | mission-repository', function() {
     it('should return all active missions', async function() {
       databaseBuilder.factory.buildMission({
         id: 2,
+        cardImageUrl: 'https://example.com/image.png',
         name: 'Alt name',
         status: Mission.status.VALIDATED,
         learningObjectives: 'Alt objectives',
@@ -165,6 +170,7 @@ describe('Integration | Repository | mission-repository', function() {
 
       databaseBuilder.factory.buildMission({
         id: 3,
+        cardImageUrl: null,
         name: 'inactive name',
         status: Mission.status.INACTIVE,
         learningObjectives: 'Alt objectives',
@@ -178,6 +184,7 @@ describe('Integration | Repository | mission-repository', function() {
 
       expect(result).to.deep.equal([new Mission({
         id: 2,
+        cardImageUrl: 'https://example.com/image.png',
         name_i18n: { fr: 'Alt name' },
         competenceId: 'competenceId',
         thematicIds: 'thematicStep1,thematicStep2,thematicDefi',
@@ -197,6 +204,7 @@ describe('Integration | Repository | mission-repository', function() {
     context('Mission creation', function() {
       it('should store mission', async function() {
         const mission = new Mission({
+          cardImageUrl: null,
           name_i18n: { fr: 'Mission impossible' },
           competenceId: 'AZERTY',
           thematicIds: 'QWERTY',
@@ -233,6 +241,7 @@ describe('Integration | Repository | mission-repository', function() {
       it('should store I18n for mission', async function() {
 
         const mission = new Mission({
+          cardImageUrl: null,
           name_i18n: { fr: 'Mission impossible' },
           competenceId: 'AZERTY',
           thematicIds: 'QWERTY',
@@ -283,6 +292,7 @@ describe('Integration | Repository | mission-repository', function() {
 
         const missionToUpdate = new Mission({
           id: savedMission.id,
+          cardImageUrl: null,
           name_i18n: { fr: 'Updated mission' },
           competenceId: 'QWERTY',
           thematicIds: 'Thematic',
@@ -327,6 +337,7 @@ describe('Integration | Repository | mission-repository', function() {
 
         const missionToUpdate = new Mission({
           id: savedMission.id,
+          cardImageUrl: null,
           name_i18n: { fr: 'Updated mission' },
           competenceId: 'QWERTY',
           thematicIds: 'Thematic',

diff --git a/api/tests/tooling/database-builder/factory/build-mission.js b/api/tests/tooling/database-builder/factory/build-mission.js
@@ -5,6 +5,7 @@ import { buildTranslation } from './build-translation.js';
 export function buildMission({
   id = databaseBuffer.nextId++,
   name = 'Ma première mission',
+  cardImageUrl = null,
   competenceId = 'competenceId',
   learningObjectives = 'Que tu sois le meilleur',
   thematicIds = 'thematicIds',
@@ -18,7 +19,7 @@ export function buildMission({
   createdAt = new Date('2010-01-04'),
 } = {}) {
 
-  const values = { id, competenceId, thematicIds, createdAt, status, introductionMediaUrl, introductionMediaType, documentationUrl };
+  const values = { id, cardImageUrl, competenceId, thematicIds, createdAt, status, introductionMediaUrl, introductionMediaType, documentationUrl };
 
   buildTranslation({
     key: `mission.${id}.name`,

diff --git a/api/tests/tooling/domain-builder/factory/build-mission.js b/api/tests/tooling/domain-builder/factory/build-mission.js
@@ -3,6 +3,7 @@ import { Mission } from '../../../../lib/domain/models/index.js';
 export function buildMission({
   id = 3,
   name = 'Ma mission',
+  cardImageUrl = null,
   competenceId = 'recCompetence1',
   thematicIds = 'recThematic1',
   createdAt = new Date('2023-10-14'),
@@ -17,6 +18,7 @@ export function buildMission({
   return new Mission ({
     id,
     name_i18n: { fr: name },
+    cardImageUrl,
     competenceId,
     thematicIds,
     createdAt,