Skip to content

Commit

Permalink
Update
Browse files Browse the repository at this point in the history
  • Loading branch information
AniketSK committed Jun 27, 2024
1 parent 7f3a055 commit e90d772
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:

- name: Create Table
run: |
python print_apk_table.py >> $GITHUB_STEP_SUMMARY
./print_apk_table.py >> $GITHUB_STEP_SUMMARY
4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ dependencies {
androidTestImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.espresso.core)

val hmsVersion = "2.9.59"
val roomKitVersion = "1.2.13"
val hmsVersion: String by project
val roomKitVersion: String by project

"01-room-kitImplementation"("live.100ms:room-kit:$roomKitVersion")

Expand Down
5 changes: 4 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ kotlin.code.style=official
# Enables namespacing of each library's R class so that its R class includes only the
# resources declared in the library itself and none from the library's dependencies,
# thereby reducing the size of the R class for that library
android.nonTransitiveRClass=true
android.nonTransitiveRClass=true
org.gradle.java.home=/Users/aniket/Applications/Android\ Studio.app/Contents/jbr/Contents/Home
roomKitVersion=1.2.15
hmsVersion=2.9.62
9 changes: 5 additions & 4 deletions print_apk_table.py
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env python3
import re
import subprocess
import sys
Expand All @@ -10,7 +11,7 @@
You can take a look at the reference project [here](https://github.com/100mslive/Android-Size-Reference-App/)
These are accuarate for sdk version `2.9.59` and room-kit version `1.2.13`.
These are accuarate for sdk version `HMS_SDK_VERSION_PLACEHOLDER` and room-kit version `HMS_ROOMKIT_VERSION_PLACEHOLDER`.
## Increase in Android APK size:
Expand Down Expand Up @@ -120,7 +121,7 @@ def writeDataToFile(data, filePath):
# Writing data to a file
doc.writelines(data)

def getArticleString():
def getArticleString(version):
article = [prefixedArticle, archTableHeader,]
# Print everything except room kit and the base
for a in archMaps:
Expand All @@ -144,5 +145,5 @@ def printEntireArchTable():
if(len(sys.argv) == 1):
printEntireArchTable()
else:
print(f"Writing article to path: {sys.argv[1]}")
writeDataToFile(getArticleString(), sys.argv[1])
print(f"Writing article for version {sys.argv[2]} to path: {sys.argv[1]}")
writeDataToFile(getArticleString(sys.argv[2]), sys.argv[1])

0 comments on commit e90d772

Please sign in to comment.