Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS-22834: Transcription parity across platforms #1793

Merged
merged 9 commits into from
Jul 2, 2024
Merged

ISS-22834: Transcription parity across platforms #1793

merged 9 commits into from
Jul 2, 2024

Conversation

Decoder07
Copy link
Contributor

Description

  • Transcription parity across platforms

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@Decoder07 Decoder07 requested a review from ygit July 1, 2024 11:37
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 09ee215 into develop Jul 2, 2024
2 checks passed
@ygit ygit deleted the ISS-22834 branch July 2, 2024 09:25
Decoder07 added a commit that referenced this pull request Jul 29, 2024
* Added transcriptions fix to be in parity with other platforms

* Updated gemfile

* Added caption fix

* Updated transcription box size

* Fixed transcription for same peer

* Updated transcription padding

* 🤖 Automated Format and Fix

* released sample app version 1.5.209 (509) 🍀

---------

Co-authored-by: Decoder07 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants