Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a example app for hms_room_kit package #1613

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Created a example app for hms_room_kit package #1613

merged 12 commits into from
Dec 11, 2023

Conversation

vinayakbot
Copy link

@vinayakbot vinayakbot commented Oct 19, 2023 •
edited
Loading

Description

This PR contains example app code for hms_room_kit package
Issue id - #1593

If the PR requires any improvements or updates please mention them i will update the package accordingly,

Additional Details

Didn't used any external dependency or library
Docs refer - https://www.100ms.live/docs/flutter/v2/quickstart/prebuilt

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@vinayakbot vinayakbot marked this pull request as ready for review October 19, 2023 17:31
@vinayakbot vinayakbot mentioned this pull request Oct 19, 2023
Closed
@ygit ygit self-requested a review October 21, 2023 07:52
ygit
ygit requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakbot Requesting some minor changes

sample apps/flutter-quickstart-app/.flutter-plugins Outdated Show resolved Hide resolved
sample apps/flutter-quickstart-app/.flutter-plugins-dependencies Outdated Show resolved Hide resolved
sample apps/hms-callkit-app/.flutter-plugins Outdated Show resolved Hide resolved
sample apps/hms-callkit-app/.flutter-plugins-dependencies Outdated Show resolved Hide resolved
packages/hms_room_kit/example/lib/presentation/features/dashbaord/dashbaord_main_view.dart Outdated Show resolved Hide resolved
@vinayakbot
Copy link
Author

@ygit did all the changes you requested please check once thanks

@Decoder07
Copy link
Contributor

@vinayakbot can you please perform the requested changes so I can merge this.

@vinayakbot vinayakbot requested a review from ygit November 10, 2023 18:34
@ygit ygit changed the base branch from main to roomKitExampleApp December 11, 2023 10:39
@ygit ygit merged commit 99ad48d into 100mslive:roomKitExampleApp Dec 11, 2023
1 check failed
@ygit
Copy link
Member

ygit commented Dec 11, 2023

@vinayakbot Congratulations! We have merged this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Decoder07 Decoder07 Awaiting requested review from Decoder07

@ygit ygit Awaiting requested review from ygit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayakbot @Decoder07 @ygit