Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added first class api for hand raise and peer list updates #1600

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Added first class api for hand raise and peer list updates #1600

merged 5 commits into from
Oct 9, 2023

Conversation

Decoder07
Copy link
Contributor

Description

  • Added first class api's for hand raise
  • Added onPeerListUpdate callback in HMSUpdateListener
  • Added handRaisedUpdated peer updated type in onPeerUpdate

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@Decoder07 Decoder07 requested a review from ygit September 28, 2023 10:46
ygit
ygit approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit fcd7559 into develop Oct 9, 2023
1 check passed
@ygit ygit deleted the feature/110-hand-raise-firstclass-api branch October 9, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Decoder07 @ygit