Skip to content

Commit

Permalink
resolved package warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ygit committed Aug 3, 2023
1 parent 7bc845b commit bf98a53
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 15 deletions.
7 changes: 3 additions & 4 deletions packages/hms_room_kit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ Once you have the prerequisites, follow the steps below to create a Flutter app.

- Create a Flutter app using the terminal; you can get the [Flutter SDK](https://docs.flutter.dev/get-started/install/macos#get-sdk) and use the below command:

```bash section=createFlutterApp
flutter create my_app
```
```bash section=createFlutterApp
flutter create my_app
```

- Once the app is created, open it in VS code.

Expand Down Expand Up @@ -195,7 +195,6 @@ HMSPrebuilt(
)));
```
### Add the 100ms Room Kit to your App
We will be adding a join button to the app, on the button click we will route the user to the 100ms room kit. To do this, follow the steps below:
Expand Down
8 changes: 3 additions & 5 deletions packages/hms_room_kit/example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,9 @@ packages:
hmssdk_flutter:
dependency: transitive
description:
path: "packages/hmssdk_flutter"
ref: "feature/prebuilt"
resolved-ref: "92160946ae065f2051322f435c2d6326bee7c7c4"
url: "https://github.com/100mslive/100ms-flutter.git"
source: git
path: "../../hmssdk_flutter"
relative: true
source: path
version: "1.8.0"
http:
dependency: transitive
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ class HmssdkFlutterPlugin :
fun build(activity: Activity, call: MethodCall, result: Result) {
val dartSDKVersion = call.argument<String>("dart_sdk_version")
val hmsSDKVersion = call.argument<String>("hmssdk_version")
val isPrebuilt = call.argument<Boolean>("is_prebuilt")?:false
val isPrebuilt = call.argument<Boolean>("is_prebuilt") ?: false
val framework = FrameworkInfo(framework = AgentType.FLUTTER, frameworkVersion = dartSDKVersion, frameworkSdkVersion = hmsSDKVersion, isPrebuilt = isPrebuilt)
val builder = HMSSDK.Builder(activity).setFrameworkInfo(framework)

Expand Down
8 changes: 3 additions & 5 deletions packages/hmssdk_flutter/example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -362,11 +362,9 @@ packages:
hmssdk_flutter:
dependency: transitive
description:
path: "packages/hmssdk_flutter"
ref: "feature/prebuilt"
resolved-ref: "92160946ae065f2051322f435c2d6326bee7c7c4"
url: "https://github.com/100mslive/100ms-flutter.git"
source: git
path: ".."
relative: true
source: path
version: "1.8.0"
http:
dependency: transitive
Expand Down

0 comments on commit bf98a53

Please sign in to comment.