Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EmailAlreadyInUse issues #56
Fix EmailAlreadyInUse issues #56
Changes from 4 commits
e9d9c0a
f40f425
8fa73e4
560cf58
80b558b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo...
verifCtx
... I think call it ..verifyCtx
..?also, what is the code doing, and why..? it looks like its making multiple attempts to encrypt and update something..? is the underlining service prone to failing / timing out..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually short for "verification context" 😄
The whole block comes directly from https://github.com/0xsequence/waas-authenticator/blob/master/rpc/sessions.go#L86.
For context, this is executed whenever the client/user responds with an answer to a challenge (e.g. after inputting code from email OR in commit/reveal flow, when the client provides the revealed auth proof). If we failed answer verification (e.g. incorrect code input by the user) AND if there is an existing verification context (always true for email flow), then we increment the attempts count in the verification context's encrypted data, re-encrypt that data, and store it back in the database.
This lets us keep track of failed attempts and prevent the user from trying every single code combination there is 😄
The one here is the same but for account federation/linking instead of authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood :) thanks for explaining, sounds good