Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit/reveal OIDC flow #47

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Commit/reveal OIDC flow #47

merged 4 commits into from
Jun 25, 2024

Conversation

patrislav
Copy link
Member

@patrislav patrislav commented May 31, 2024

This adds support for the new OIDC commit/reveal flow & guest accounts.

Base automatically changed from waas-auth-v2 to master June 6, 2024 10:58
@patrislav patrislav marked this pull request as ready for review June 19, 2024 16:24
"github.com/0xsequence/waas-authenticator/rpc/tenant"
)

type AuthProvider struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any tests for those new providers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some basic success-scenario tests. Planning to expand them much further later on

Copy link
Contributor

@marino39 marino39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrislav patrislav merged commit b117700 into master Jun 25, 2024
2 checks passed
@patrislav patrislav deleted the commit-reveal-oidc branch June 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants