228 marketplace reader support #263
Open
+2,202
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZemindJan
force-pushed
the
228-marketplace-reader-support
branch
from
6c2ea09 to
bd6b8e9
Compare
Comment on lines
+223
to
+224
| void AGeneralTesting::TestListCurrencies() const | ||
| { |
There was a problem hiding this comment.
Thank you for including tests! Is it possible to incorporate these into the automated tests in the SequenceTests plugin?
| @@ -462,3 +466,203 @@ void SequenceAPITest::TestLoadTransakUrl() | |||
| Api->OpenTransakLink(); | |||
| } | |||
| } | |||
|
|
|||
| void SequenceAPITest::ListCurrencies(TFunction<void(FString)> OnSuccess, | |||
There was a problem hiding this comment.
How do I run these?
| @@ -52,7 +52,6 @@ FJsonArray FJsonBuilder::AddArray(FString Name) | |||
|
|
|||
| FString FJsonBuilder::ToString() const | |||
| { | |||
| auto x = 3; | |||
| TSharedPtr<FJsonObject> feeJsonObject = USequenceSupport::JsonStringToObject(feeValue->AsString()); | ||
| fee.Setup(*feeJsonObject); | ||
| FeeBreakdown.Add(fee); | ||
| //TSharedPtr<FJsonObject> feeJsonObject = USequenceSupport::JsonStringToObject(feeValue->AsString()); |
There was a problem hiding this comment.
Can we remove this?
There was a problem hiding this comment.
Can we add the other read methods to blueprints as well?
| OrderArray.Empty(); | ||
|
|
||
| return ListAllCollectibleListingsWithLowestPriceListingsFirstHelper(ChainID, ContractAddress, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Orders, const bool IsDone) |
There was a problem hiding this comment.
Is this the right helper?
| OrderArray.Empty(); | ||
|
|
||
| return ListAllCollectibleListingsWithLowestPriceListingsFirstHelper(ChainID, ContractAddress, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Orders, const bool IsDone) |
There was a problem hiding this comment.
Is this the right helper?
Comment on lines
73
to
100
| void ListCurrencies(const int64 ChainID, TSuccessCallback<FSeqListCurrenciesReturn> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, filter, page | ||
| void ListCollectibleListingsWithLowestPriceListingsFirst(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TSuccessCallback<FSeqListCollectiblesReturn> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, filter | ||
| void ListAllCollectibleListingsWithLowestPriceListingsFirst(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, filter, page | ||
| void ListCollectibleOffersWithHighestPricedOfferFirst(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TSuccessCallback<FSeqListCollectiblesReturn> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, filter | ||
| void ListAllCollectibleOffersWithHighestPricedOfferFirst(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void GetLowestPriceOfferForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const TSuccessCallback<FSeqCollectibleOrder>& OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void GetHighestPriceOfferForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const TSuccessCallback<FSeqCollectibleOrder>& OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void GetLowestPriceListingForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const TSuccessCallback<FSeqCollectibleOrder>& OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void GetHighestPriceListingForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const TSuccessCallback<FSeqCollectibleOrder>& OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter, page | ||
| void ListListingsForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TSuccessCallback<FSeqListCollectibleListingsReturn> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void ListAllListingsForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter, page | ||
| void ListOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TSuccessCallback<FSeqListCollectibleOffersReturn> OnSuccess, const FFailureCallback& OnFailure); | ||
| // Takes address, tokenId, filter | ||
| void ListAllOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure); | ||
| // takes address, filter | ||
| void GetFloorOrder(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, const TSuccessCallback<FSeqCollectibleOrder>& OnSuccess, const FFailureCallback& OnFailure); | ||
| }; |
There was a problem hiding this comment.
I noticed you've added comments for the function params; thank you! I was wondering, do you think we could make these intellisense summaries? Might be a nice value add for devs who go the C++ integration route. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.