Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass interface to Client + other improvements #44

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Conversation

klaidliadon
Copy link
Contributor

This PR does the following:

  • allows to pass a proto.QuotaControl to the NewClient function: if it's nil, it is going to behave as usual by creating a new client using the configuration, otherwise it's going to use the passed instance which could be the server implementation, for instance.
  • Adds a new service to the enum
  • Adds a new SessionType User, that is enabled by passing a UserStore. When there's a Wallet session type, it uses the store to lookup for the user. If a user is found the session type gets upgraded from Wallet to User
  • Changes the ACL to have more flexibility. Instead of only a minimum level, a series of levels can be specified. The ACL is now an integer encodes the level as bits (Public is bit 0, AccessKey is bit 1 and so on)

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/proto.go Outdated Show resolved Hide resolved
@klaidliadon klaidliadon merged commit 6021ef9 into master Sep 13, 2024
1 check passed
@klaidliadon klaidliadon deleted the builder branch September 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants