no redis counter if redis disabled

0xsequence · Feb 26, 2024 · fc8529d · fc8529d
1 parent dac8a3d
commit fc8529d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/config.go b/config.go
@@ -31,6 +31,10 @@ type Config struct {
 }
 
 func (cfg Config) RedisRateLimitConfig() *httprateredis.Config {
+	if !cfg.Redis.Enabled {
+		return nil
+
+	}
 	return &httprateredis.Config{
 		Host:      cfg.Redis.Host,
 		Port:      cfg.Redis.Port,

diff --git a/ratelimiter.go b/ratelimiter.go
@@ -22,7 +22,10 @@ func NewHTTPRateLimiter(cfg Config, vary RateLimitVaryFn) func(next http.Handler
 	// httprate limit counter
 	const _DefaultRPM = 120
 
-	limitCounter, _ := httprateredis.NewRedisLimitCounter(cfg.RedisRateLimitConfig())
+	var limitCounter httprate.LimitCounter
+	if redisCfg := cfg.RedisRateLimitConfig(); redisCfg != nil {
+		limitCounter, _ = httprateredis.NewRedisLimitCounter(redisCfg)
+	}
 
 	limitErr := proto.ErrLimitExceeded
 	if cfg.RateLimiter.ErrorMessage != "" {