Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support walking slices, recursive types & prepare for fetching secrets in batches #8

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

VojtechVitek
Copy link
Contributor

@VojtechVitek VojtechVitek commented Oct 3, 2024

  • Walk any given config recursively (support nested structs, double-indirection etc.)
  • Support slices and arrays
  • Return slice of fields that were collected for secret hydration -- this will allow us to fetch secrets in batches, if supported by the provider

Possible limitation: If there is a circular dependency in the given config, we might hit an endless recursion. But is that even possible for configs? Perhaps we could add a limit on the depth of recursion.

@VojtechVitek VojtechVitek changed the title Support walking slices Support walking slices & prepare for fetching secrets in batches Oct 4, 2024
@VojtechVitek VojtechVitek changed the title Support walking slices & prepare for fetching secrets in batches Support walking slices, recursive types & prepare for fetching secrets in batches Oct 4, 2024
@VojtechVitek VojtechVitek merged commit ade4468 into master Oct 4, 2024
1 check passed
@VojtechVitek VojtechVitek deleted the fix_walking_slice branch October 4, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants