RPC version 0.4.0 #157
Merged
RPC version 0.4.0 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 17, 2023 13:04
# Conflicts: # crates/starknet/src/transactions/mod.rs
# Conflicts: # crates/starknet-server/src/api/json_rpc/endpoints.rs # crates/starknet-server/src/api/utils.rs # crates/starknet-server/tests/common/devnet.rs # crates/starknet/src/transactions/mod.rs # crates/types/src/rpc/transactions.rs
…factoring # Conflicts: # crates/starknet/src/transactions/mod.rs
# Conflicts: # crates/starknet-server/src/api/json_rpc/endpoints.rs # crates/starknet/src/starknet/add_declare_transaction.rs # crates/starknet/src/starknet/add_deploy_account_transaction.rs # crates/starknet/src/starknet/add_invoke_transaction.rs # crates/starknet/src/starknet/mod.rs # crates/starknet/src/state/mod.rs # crates/starknet/src/transactions/declare_transaction.rs # crates/starknet/src/transactions/declare_transaction_v2.rs # crates/starknet/src/transactions/deploy_account_transaction.rs # crates/starknet/src/transactions/invoke_transaction.rs # crates/types/src/error.rs # crates/types/src/rpc.rs
added 10 commits
September 2, 2023 08:29
….4.0/sr-version-raised # Conflicts: # crates/starknet-server/src/api/json_rpc/models.rs # crates/starknet/src/starknet/add_invoke_transaction.rs # crates/starknet/src/starknet/mod.rs
|
there are multiple conflicts, which must be resolved. This will lead to fewer lines changed |
# Conflicts: # Cargo.lock # crates/starknet-server/src/api/json_rpc/endpoints.rs # crates/starknet-server/src/api/json_rpc/models.rs # crates/starknet-server/src/api/json_rpc/write_endpoints.rs # crates/starknet/src/starknet/add_declare_transaction.rs # crates/starknet/src/starknet/add_deploy_account_transaction.rs # crates/starknet/src/starknet/add_invoke_transaction.rs # crates/starknet/src/starknet/mod.rs # crates/starknet/src/transactions.rs # crates/starknet/src/utils.rs # crates/types/src/rpc.rs # crates/types/src/rpc/block.rs # crates/types/src/rpc/transactions.rs
Done |
FabijanC
requested changes
Sep 5, 2023
ivpavici
reviewed
Sep 5, 2023
marioiordanov
approved these changes
Sep 6, 2023
…eShard/starknet-devnet-rs into cases/rpc-0.4.0/sr-version-raised
# Conflicts: # crates/starknet-server/tests/get_transaction_receipt_by_hash.rs
FabijanC
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Some models moved into types. Test example modifications, ability to export test artifacts under separate feature flag.
Checklist:
./scripts/format.sh./scripts/clippy_check.shcargo test