Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Show some message while app is building #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fvictorio
Copy link
Contributor

Closes #5. Depends on 0xProject/0x-launch-kit-frontend#499 being merged and the new image being published.

This copies a template showing a message before starting to build the app. After the build finishes, the message is overwritten by the built app.


Some extra details in case anyone cares:

First, I had to serve the assets from production-build instead of build, because create-react-app cleans the whole build directory when it starts, and so the message was being deleted.

I also added a depends_on: nginx to the frontend container. Nginx adds its own index.html when it starts, and it can overwrite the copied template. With this dependency, we guarantee that the shown index.html is the one we copied.

Copy link

@1Blackdiamondsc 1Blackdiamondsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show some message while app is building

@GAEAlimited
Copy link

Hey @fvictorio, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #6

#6

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

GAEAlimited added a commit to GAEAlimited/0x-launch-kit that referenced this pull request Jun 27, 2024
GAEAlimited added a commit to GAEAlimited/0x-launch-kit that referenced this pull request Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something wrong with your containers
3 participants