Refactor recursion params #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: evm_arithmetization
sai-deng
requested review from
Nashtare,
atanmarko,
0xaatif,
wborgeaud and
LindaGuiga
as code owners
0xaatif
approved these changes
Nov 5, 2024
Nashtare
approved these changes
Nov 5, 2024
Comment on lines
626
to
630
| /// Optional configuration for the shrinking circuit. | ||
| pub shrinking_circuit_config: CircuitConfig, | ||
| /// Optional configuration for the recursion circuits. | ||
| pub recursion_circuit_config: CircuitConfig, | ||
| /// Optional recursion threshold in degree bits. |
There was a problem hiding this comment.
doc says these are optional, seems there's a type mismatch?
Co-authored-by: Robin Salen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @Nashtare 's comments in #739