perf: Reduce KERNEL / MemBefore size #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
wborgeaud,
muursh and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
|
Had to revert snarkv precompile initialization of calldata, which made it go over the limit again. Will reopen once additional gains are brought in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More could be done here and there, but this is sufficient to bring all KERNEL variants' lengths down under 65536 with some margin, so that initial
MemBeforetable of all segment batches is padded to a smaller power of 2.Mostly revolves around:
PUSH @CONSTANTwithDUPNote that we are considering adding some INCR / DECR privileged instruction, which would increase the KERNEL code length safety margin in case of future increase.