Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplaced overflow check in wcopy #661

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix misplaced overflow check in wcopy #661

merged 1 commit into from
Sep 26, 2024

Conversation

Nashtare
Copy link
Collaborator

The u32 overflow check should be happening after we check for too large offsets, as these are valid cases that would otherwise trigger a fault_exception.

Caught by some regression on the Ethereum test suite (calldatacopy_d7g0v0_Cancun notably).

@Nashtare Nashtare added the bug Something isn't working label Sep 25, 2024
@Nashtare Nashtare added this to the Testing and Validation milestone Sep 25, 2024
@Nashtare Nashtare self-assigned this Sep 25, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Sep 25, 2024
hratoanina
hratoanina approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@hratoanina hratoanina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashtare Nashtare merged commit c9caaa1 into develop Sep 26, 2024
16 checks passed
@Nashtare Nashtare deleted the fix/overflow_check branch September 26, 2024 13:47
4l0n50 added a commit that referenced this pull request Oct 22, 2024
@4l0n50
Add fix from PR #661
8a32380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hratoanina hratoanina hratoanina approved these changes

@muursh muursh muursh approved these changes

@wborgeaud wborgeaud Awaiting requested review from wborgeaud wborgeaud is a code owner

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

Assignees

@Nashtare Nashtare

Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashtare @muursh @hratoanina