-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip missing Cancun bits for non Eth mainnet chains #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
0xaatif,
muursh,
atanmarko and
LindaGuiga
as code owners
September 6, 2024 21:11
github-actions
bot
added
crate: trace_decoder
Anything related to the trace_decoder crate.
crate: proof_gen
Anything related to the proof_gen crate.
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
labels
Sep 6, 2024
Nashtare
modified the milestones:
Type 1 - Ethereum Mainnet,
Type 1 - Polygon PoS / shadow proving (Q4 2024)
Sep 6, 2024
Nashtare
force-pushed
the
feat/ignore_cancun_bits
branch
from
September 7, 2024 20:38
2a5f878
to
010c53a
Compare
atanmarko
reviewed
Sep 11, 2024
atanmarko
reviewed
Sep 11, 2024
atanmarko
approved these changes
Sep 11, 2024
atanmarko
reviewed
Sep 11, 2024
Nashtare
force-pushed
the
feat/ignore_cancun_bits
branch
from
September 11, 2024 13:09
5771c27
to
0b71dc0
Compare
0xaatif
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crate: common
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
crate: proof_gen
Anything related to the proof_gen crate.
crate: trace_decoder
Anything related to the trace_decoder crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #562
Includes:
eth_mainnet
)trace_decoder
directly take theburn_address
from the data provided by therpc
module (forcdk_erigon
feature)Tested against a Polygon PoS RPC endpoint provided by @praetoriansentry and I managed to generate witness payloads with the
rpc
binary.