Fix selfdestruct for EIP-6780 with non-empty balances #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
0xaatif
reviewed
Aug 15, 2024
| @@ -209,6 +211,28 @@ fn process_nonce( | |||
| }) | |||
| } | |||
|
|
|||
| /// Processes the self destruct for the given account state. | |||
| fn process_self_destruct( | |||
There was a problem hiding this comment.
nit: returning an Option is a bit cryptic - could you document what it means?
There was a problem hiding this comment.
Also you never return Some(false), which feels odd
There was a problem hiding this comment.
to be fair I just brought back what had been removed from a previous PR, but I can change it
There was a problem hiding this comment.
I believe it's done that way to easily skip serde from serializing None variants, without having to provide a custom fn to deal with false values, given that these are 99% of the cases encountered. But I could be wrong.
muursh
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue actually lied in the application of #461, that claimed to change only the native tracer behavior but actually removed the notion of self destructed accounts from jerigon payloads as well.
This was also incorrect, following the EIP specification of still considering as contract creation accounts with non-empty balances.
I've added a new test case from the previously failing payload b20472570 (cf #475).
closes #475