Allow features with macros within macros #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
einar-polygon
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
As demonstrated by the test, this correctly adds the capability to expand a macro invocation inside of a conditional block (feature guard).
I note that arbitrary nesting of macros and conditional blocks are not intended to be supported, and would likely require mutually recursive expansion of macros and conditional blocks. We agree that this can be added based on future demand but is out of scope for this PR.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation of conditional blocks, we cannot have conditional blocks including macros within a macro. This PR aims at allowing such a case scenario.