Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix SELFDESTRUCT" #491

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Revert "Fix SELFDESTRUCT" #491

merged 1 commit into from
Aug 14, 2024

Conversation

Nashtare
Copy link
Collaborator

This was an erroneous fix, where the issue actually lied in the parsing of the Jerigon payload that didn't carry the actual account deletion information. More on this in #475.

The gist of it (from EIP-6780)

A contract is considered created at the beginning of a create transaction or when a CREATE series operation begins execution (CREATE, CREATE2, and other operations that deploy contracts in the future). If a balance exists at the contract’s new address it is still considered to be a contract creation.

This reverts commit 092d98b.
@Nashtare Nashtare self-assigned this Aug 13, 2024
@Nashtare Nashtare requested a review from muursh as a code owner August 13, 2024 22:56
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 13, 2024
@Nashtare Nashtare merged commit c6d015b into develop Aug 14, 2024
15 checks passed
@Nashtare Nashtare deleted the revert-487-fix-selfdestruct branch August 14, 2024 01:18
atanmarko pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant