-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize cli params and rename some types #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: proof_gen
Anything related to the proof_gen crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
labels
Aug 12, 2024
atanmarko
force-pushed
the
chore/cleanup-ci
branch
from
August 12, 2024 11:58
ad46801
to
eb7ed92
Compare
atanmarko
force-pushed
the
chore/cleanup-ci
branch
from
August 12, 2024 11:58
eb7ed92
to
632d4e2
Compare
Nashtare
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
0xaatif
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this change
muursh
approved these changes
Aug 13, 2024
Nashtare
force-pushed
the
chore/cleanup-ci
branch
from
August 13, 2024 21:31
49bd47f
to
6e7d0ba
Compare
@Nashtare Thanks, I was just about to fix ranges |
Nashtare
added a commit
that referenced
this pull request
Aug 15, 2024
* chore: reorganize cli params and rename some types * fix: docker compose test * fix: set default values * fix: tweak hardcoded ranges --------- Co-authored-by: Robin Salen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crate: proof_gen
Anything related to the proof_gen crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.