Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize cli params and rename some types #485

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

atanmarko
Copy link
Member

No description provided.

@atanmarko atanmarko self-assigned this Aug 12, 2024
@github-actions github-actions bot added crate: proof_gen Anything related to the proof_gen crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Aug 12, 2024
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

zero_bin/prover/src/cli.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this change

@atanmarko
Copy link
Member Author

@Nashtare Thanks, I was just about to fix ranges

@atanmarko atanmarko merged commit 7d8fece into feat/continuations Aug 13, 2024
14 checks passed
@atanmarko atanmarko deleted the chore/cleanup-ci branch August 13, 2024 21:50
Nashtare added a commit that referenced this pull request Aug 15, 2024
* chore: reorganize cli params and rename some types

* fix: docker compose test

* fix: set default values

* fix: tweak hardcoded ranges

---------

Co-authored-by: Robin Salen <[email protected]>
@Nashtare Nashtare added this to the x Misc. milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: proof_gen Anything related to the proof_gen crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants