Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize flaky inputs as 'json' files #420

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Nashtare
Copy link
Collaborator

When passing --save-inputs-on-error flag, we automatically write to disk the GenerationInputs that caused the proof generation to fail. The current extension is .log which is a bit confusing, especially as we serialize them into a pretty JSON string.

@Nashtare Nashtare added this to the Misc. milestone Jul 20, 2024
@Nashtare Nashtare self-assigned this Jul 20, 2024
@Nashtare Nashtare requested a review from muursh as a code owner July 20, 2024 18:19
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Jul 20, 2024
@Nashtare
Copy link
Collaborator Author

Note that this doesn't remove the inputs logging logic for aggregation proofs, though proving failures due to inconsistent witness (typically Wire set twice) currently yields a panic! on plonky2 side, which isn't caught by zero-bin. We should consider either removing the logging logic for aggregation proofs altogether, or refactor plonky2 proof generation to gracefully error when setting the wires.

If we lean towards the latter, I'd rather have it done soon given we'll have to do a v.1.0.0 release following the subgroup generator change anyway.

@Nashtare Nashtare merged commit e3602e1 into develop Jul 22, 2024
14 checks passed
@Nashtare Nashtare deleted the extension/debug_inputs branch July 22, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants