feat: add conditional feature support in the kernel assembly #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
added
enhancement
muursh
approved these changes
Jul 23, 2024
Nashtare
added a commit
that referenced
this pull request
Aug 31, 2024
* feat: add conditional feature support in the kernel * Clippy * Never enough clippy * Wording * Update doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #409
I ended up using a more general approach to handle arbitrary chunks of code within conditional blocks (initial description in #409 was only mentioning skipping code between two global labels, not it handles arbitrary chunks).
Now anything between:
will be ignored.