Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add caching for get_block #346

Merged
merged 6 commits into from
Jul 8, 2024
Merged

feat: add caching for get_block #346

merged 6 commits into from
Jul 8, 2024

Conversation

atanmarko
Copy link
Member

Resolves #325

@atanmarko atanmarko self-assigned this Jul 1, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Jul 1, 2024
@atanmarko atanmarko marked this pull request as ready for review July 1, 2024 16:32
Nashtare
Nashtare approved these changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marko!
Tested on a span of 4 consecutive blocks and works fine (130 RPC requests in total).

zero_bin/rpc/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the crate: mpt_trie Anything related to the mpt_trie crate. label Jul 8, 2024
@atanmarko atanmarko merged commit 341c322 into develop Jul 8, 2024
14 checks passed
@atanmarko atanmarko deleted the feat/cached-provider branch July 8, 2024 09:54
@Nashtare Nashtare mentioned this pull request Jul 9, 2024
Merged
@Nashtare Nashtare added this to the Type 1 - Q3 2024 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh

Assignees

@atanmarko atanmarko

Labels
crate: mpt_trie Anything related to the mpt_trie crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Type 1 - Ethereum Mainnet
Development

Successfully merging this pull request may close these issues.

Cache prev_hashes input prover data
2 participants
@atanmarko @Nashtare