Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: zero-bin is now able again to accesses evm_arithmetization for circuit versions #310

Merged
merged 12 commits into from
Aug 15, 2024
Merged

Fix: zero-bin is now able again to accesses evm_arithmetization for circuit versions #310

merged 12 commits into from
Aug 15, 2024

Commits on Aug 13, 2024

  1. Requested PR changes for #310

    @BGluth
    BGluth committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ed6fe27 View commit details
    Browse the repository at this point in the history

  2. Requested changes for PR #310 

    - Renamed "CARGO_WORKSPACE_DIR" --> "ZK_EVM_WORKSPACE_DIR".
    @BGluth
    BGluth committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2453350 View commit details
    Browse the repository at this point in the history

  3. Made the error for circuit dir creation better

    @BGluth
    BGluth committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f74037b View commit details
    Browse the repository at this point in the history

  4. Fixed missing segment in circuit path 

    - Was missing `zero_bin`.
- Also made the circuit directory error a bit more helpful (now also
  contains underlying IO error).
    @BGluth
    BGluth committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c42e9c4 View commit details
    Browse the repository at this point in the history

  5. Now uses the kernel hash to version circuits 

    - Realized that the kernel hash is the best indicator if two serialized
  circuits were built using a compatable kernel.
    @BGluth
    BGluth committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    acf9c1f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Removed evm_arithmetic versioning variable 

    - I don't think we really have a use for this anymore if we are relying
  solely on the kernel hash for circuit versioning.
- Also swapped out the `evm_arithmetization` versioning variable with
  the kernel hash.
    @BGluth
    BGluth committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ee06ceb View commit details
    Browse the repository at this point in the history

  2. Missed clippy pass

    @BGluth
    BGluth committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    816eb88 View commit details
    Browse the repository at this point in the history

  3. Requested PR changes for #310 (2)

    @BGluth
    BGluth committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3f3a66c View commit details
    Browse the repository at this point in the history

  4. Removed unused env var ZK_EVM_WORKSPACE_DIR

    @BGluth
    BGluth committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d4f4b4b View commit details
    Browse the repository at this point in the history

  5. Fixed circuit dir creation issue 

    - If the directory path that we needed to create contained more than `1`
  directory, it would fail.
    @BGluth
    BGluth committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0722475 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Update zero_bin/common/src/prover_state/persistence.rs 

    Co-authored-by: Robin Salen <[email protected]>
    @BGluth @Nashtare
    BGluth and Nashtare authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ce5c9e7 View commit details
    Browse the repository at this point in the history

  2. Requested PR changes for #310 (3)

    @BGluth
    BGluth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2928aec View commit details
    Browse the repository at this point in the history