migrate compat to trace_decoder crate #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
0xaatif
requested changes
Jun 21, 2024
There was a problem hiding this comment.
I like this change, and the rationale, but trace_decoder::types is going away pretty soon: #309.
Can you break this out into a compact micro-crate, with publish = false, and we can decide on it's final resting place when the dust settles?
frisitano
force-pushed
the
feat/migrate-compat
branch
2 times, most recently
from
2e2adb0
to
e86adff
Compare
github-actions
bot
removed
the
crate: trace_decoder
frisitano
force-pushed
the
feat/migrate-compat
branch
2 times, most recently
from
455359e
to
1dcbf4e
Compare
0xaatif
approved these changes
Jun 23, 2024
Closed
frisitano
force-pushed
the
feat/migrate-compat
branch
from
5a9c290
to
3b83313
Compare
0xaatif
approved these changes
Jun 23, 2024
atanmarko
reviewed
Jun 24, 2024
atanmarko
approved these changes
Jun 24, 2024
0xaatif
approved these changes
Jun 24, 2024
muursh
approved these changes
Jun 24, 2024
|
@frisitano Could you rebase so that we can merge? |
frisitano
force-pushed
the
feat/migrate-compat
branch
from
27b97a5
to
254491b
Compare
frisitano
force-pushed
the
feat/migrate-compat
branch
from
254491b
to
10702d1
Compare
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes that we migrate the
Compattrait totrace_decoder::types. The rationale behind this migration is such that if there are clients that alloy based which want to integrate with the trace protocol they should not have to import therpccrate to get access to theCompattrait and associated conversions. A concrete example of this is the integration ofrethwhich isalloybased.