Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
temaniarpit27 committed Sep 19, 2024
1 parent 709250b commit 7fdcbbb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions zero/src/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ use crate::ops;
//
// While proving a block interval, we will output proofs corresponding to block
// batches as soon as they are generated.
const DEFAULT_PARALLEL_BLOCK_PROVING_PERMIT_POOL_SIZE: usize = 16;
static PARALLEL_BLOCK_PROVING_PERMIT_POOL: Semaphore = Semaphore::const_new(0);

#[derive(Debug, Clone)]
Expand Down Expand Up @@ -247,7 +246,7 @@ pub async fn prove(
PARALLEL_BLOCK_PROVING_PERMIT_POOL.add_permits(prover_config.block_pool_size);
} else {
anyhow::bail!(
"block_pool_size should be greater than 0, value passed from cli is {}",
"block_pool_size should be greater than 0, cli parameter value is {}",
prover_config.block_pool_size
);
}
Expand Down
3 changes: 2 additions & 1 deletion zero/src/prover/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ pub struct CliProverConfig {
/// generate one proof file.
#[arg(long, default_value_t = 8)]
block_batch_size: usize,
/// The maximum number of block proving tasks that can run in parallel.
/// The maximum number of block proving tasks that can run in parallel. Must
/// be greater than zero.
#[arg(long, default_value_t = 16)]
block_pool_size: usize,
}
Expand Down

0 comments on commit 7fdcbbb

Please sign in to comment.