Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish passed tests #42

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

Nashtare
Copy link
Contributor

@Nashtare Nashtare commented Dec 3, 2023

This makes a distinction between passed tests from a witness-only run vs a proving run, as there is currently no distinction. Now:

  • calling -w when running with the -p argument will skip all previously passed tests, regardless of the type of run they went through
  • calling -p without specifying -w will only discard previously passed tests with full proving enabled (and will re-run tests where only witness was generated).

I initially wanted to have something like:

pub(crate) enum PassState {
    Passed(PassedStatus),
    Ignored,
    Failed,
    #[default]
    NotRun,
}

but it seems serde and CSV writer don't work well with nested enums?

closes #40

Copy link
Collaborator

@BGluth BGluth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Didn't occur to me when I added the witness only flag.

@Nashtare Nashtare merged commit 994caa0 into 0xPolygonZero:main Dec 4, 2023
2 checks passed
@Nashtare Nashtare deleted the distinction_witness branch December 4, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish Passed status for full runs and witness-gen only
2 participants