Skip to content

Commit

Permalink
todo
Browse files Browse the repository at this point in the history
  • Loading branch information
0xaatif committed May 15, 2024
1 parent 9bbfe3b commit 99c196f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
9 changes: 6 additions & 3 deletions leader/src/mpt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ pub fn apply_diffs(
mpt.insert(
address2nibbles(*addr),
__ethers_for_compat::utils::rlp::encode(&account).to_vec(),
) // TODO(aatifsyed): make the required change to evm_arithmetization
)
.unwrap();
} else {
let old = mpt
Expand Down Expand Up @@ -375,6 +375,9 @@ pub fn trim(
}

fn into_uint(hash: B256) -> U256 {
U256::from_be_bytes(*hash) // TODO(aatifsyed): is this
// right?
// TODO(aatifsyed): unclear if this is correct.
#[cfg(target_endian = "little")]
return U256::from_le_bytes(*hash);
#[cfg(target_endian = "big")]
return U256::from_be_bytes(*hash);
}
4 changes: 3 additions & 1 deletion leader/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ pub fn has_storage_deletion(trace: &GethTrace) -> bool {
false
}
/// This crate wants to use [`alloy`], but [`evm_arithmetization`] uses
/// [`ethers`] etc. Migrating our dependencies is tracked by TODO(aatifsyed)
/// [`ethers`](__ethers_for_compat) etc.
///
/// Migrating our dependencies is tracked by [zk_evm#226](https://github.com/0xPolygonZero/zk_evm/issues/229)
pub mod compat {
use std::array;

Expand Down

0 comments on commit 99c196f

Please sign in to comment.