Feature/onchain non merklized credential converter #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-korotya
requested review from
Kolezhniuk,
volodymyr-basiuk and
vmidyllic
Kolezhniuk
previously approved these changes
Nov 25, 2024
volodymyr-basiuk
previously approved these changes
Nov 25, 2024
vmidyllic
requested changes
Nov 25, 2024
|
for me it is not enough vision how it is used in the handler, because you define public functions and it is not clear if it is enough. |
Kolezhniuk
reviewed
Nov 25, 2024
| import { Options } from '@iden3/js-jsonld-merklization'; | ||
| import { W3CCredential } from '../../verifiable'; | ||
| import { OnchainNonMerklizedIssuerAdapter } from './onchain-issuer-adapter/non-merklized/version/v0.0.1/onchain-non-merklized-issuer-adapter'; | ||
| import { EthConnectionConfig } from '..'; |
ilya-korotya
requested review from
Kolezhniuk,
volodymyr-basiuk and
vmidyllic
vmidyllic
reviewed
Dec 2, 2024
.../onchain-issuer-adapter/non-merklized/version/v0.0.1/onchain-non-merklized-issuer-adapter.ts
Outdated
Show resolved
Hide resolved
vmidyllic
reviewed
Dec 2, 2024
.../onchain-issuer-adapter/non-merklized/version/v0.0.1/onchain-non-merklized-issuer-adapter.ts
Outdated
Show resolved
Hide resolved
vmidyllic
previously approved these changes
Dec 3, 2024
| @@ -0,0 +1,13 @@ | |||
| import { Id, DID } from '@iden3/js-iden3-core'; | |||
There was a problem hiding this comment.
fix linter please
volodymyr-basiuk
previously approved these changes
Dec 3, 2024
Kolezhniuk
previously approved these changes
Dec 3, 2024
ilya-korotya
dismissed stale reviews from Kolezhniuk, volodymyr-basiuk, and vmidyllic
via
b7ab542
volodymyr-basiuk
approved these changes
Dec 3, 2024
vmidyllic
reviewed
Dec 4, 2024
vmidyllic
approved these changes
Dec 4, 2024
ilya-korotya
deleted the
feature/onchain-non-merklized-credential-converter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.